Move linters to pre-commit

christophfroehlich · christophfroehlich · commit d6d4b7032817 · 2025-12-06T22:51:12.000Z
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -75,3 +75,37 @@ repos:
     rev: v3.21.2
     hooks:
       - id: pyupgrade
+
+  - repo: local
+    hooks:
+      - id: ament_cppcheck
+        name: ament_cppcheck
+        description: Static code analysis of C/C++ files.
+        entry: env AMENT_CPPCHECK_ALLOW_SLOW_VERSIONS=1 ament_cppcheck
+        language: system
+        files: \.(h\+\+|h|hh|hxx|hpp|cuh|c|cc|cpp|cu|c\+\+|cxx|tpp|txx)$
+      - id: ament_cpplint
+        name: ament_cpplint
+        description: Static code analysis of C/C++ files.
+        entry: ament_cpplint
+        language: system
+        files: \.(h\+\+|h|hh|hxx|hpp|cuh|c|cc|cpp|cu|c\+\+|cxx|tpp|txx)$
+        args: ["--linelength=100", "--filter=-whitespace/newline"]
+      - id: ament_lint_cmake
+        name: ament_lint_cmake
+        description: Check format of CMakeLists.txt files.
+        entry: ament_lint_cmake
+        language: system
+        files: CMakeLists\.txt$
+      - id: ament_copyright
+        name: ament_copyright
+        description: Check if copyright notice is available in all files.
+        entry: ament_copyright
+        language: system
+        exclude: .*/conf\.py$
+      - id: ament_flake8
+        name: ament_flake8
+        description: Check Python code style using flake8.
+        language: system
+        types: [python]
+        entry: ament_flake8
diff --git a/example/CMakeLists.txt b/example/CMakeLists.txt
@@ -36,12 +36,6 @@ rclcpp_components_register_node(minimal_publisher
 )
 
 if(BUILD_TESTING)
-  find_package(ament_lint_auto REQUIRED)
-  set(ament_cmake_cpplint_FOUND TRUE) # Conflicts with clang-foramt
-  set(ament_cmake_flake8_FOUND TRUE) # Conflicts with black
-  set(ament_cmake_uncrustify_FOUND TRUE) # Conflicts with clang-format
-  ament_lint_auto_find_test_dependencies()
-
   find_package(ament_cmake_gtest REQUIRED)
   # example_test_gtest
   add_rostest_with_parameters_gtest(test_example_gtest test/example_test_gtest.cpp
diff --git a/example/package.xml b/example/package.xml
@@ -20,9 +20,6 @@
 
   <buildtool_export_depend>ament_cmake_core</buildtool_export_depend>
 
-  <test_depend>ament_lint_auto</test_depend>
-  <test_depend>ament_lint_common</test_depend>
-
   <export>
     <build_type>ament_cmake</build_type>
   </export>
diff --git a/example_cmake_python/package.xml b/example_cmake_python/package.xml
@@ -17,9 +17,6 @@
 
   <buildtool_depend>ament_cmake_python</buildtool_depend>
 
-  <test_depend>ament_lint_auto</test_depend>
-  <test_depend>ament_lint_common</test_depend>
-
   <export>
     <build_type>ament_cmake</build_type>
   </export>
diff --git a/example_external/CMakeLists.txt b/example_external/CMakeLists.txt
@@ -50,12 +50,4 @@ install(
 ament_export_targets(export_generate_parameter_library_example_external HAS_LIBRARY_TARGET)
 ament_export_dependencies(rclcpp rclcpp_components generate_parameter_library_example)
 
-if(BUILD_TESTING)
-  find_package(ament_lint_auto REQUIRED)
-  set(ament_cmake_cpplint_FOUND TRUE) # Conflicts with clang-foramt
-  set(ament_cmake_flake8_FOUND TRUE) # Conflicts with black
-  set(ament_cmake_uncrustify_FOUND TRUE) # Conflicts with clang-format
-  ament_lint_auto_find_test_dependencies()
-endif()
-
 ament_package()
diff --git a/example_external/package.xml b/example_external/package.xml
@@ -20,9 +20,6 @@
 
   <buildtool_export_depend>ament_cmake_core</buildtool_export_depend>
 
-  <test_depend>ament_lint_auto</test_depend>
-  <test_depend>ament_lint_common</test_depend>
-
   <export>
     <build_type>ament_cmake</build_type>
   </export>
diff --git a/example_python/package.xml b/example_python/package.xml
@@ -15,9 +15,6 @@
   <depend>generate_parameter_library_py</depend>
   <depend>rclpy</depend>
 
-  <test_depend>ament_copyright</test_depend>
-  <test_depend>ament_flake8</test_depend>
-  <test_depend>ament_pep257</test_depend>
   <test_depend>python3-pytest</test_depend>
 
   <export>
diff --git a/example_python/test/test_copyright.py b/example_python/test/test_copyright.py
diff --git a/example_python/test/test_flake8.py b/example_python/test/test_flake8.py
diff --git a/example_python/test/test_pep257.py b/example_python/test/test_pep257.py
diff --git a/generate_parameter_library/CMakeLists.txt b/generate_parameter_library/CMakeLists.txt
@@ -9,14 +9,6 @@ install(
   DESTINATION share/generate_parameter_library
 )
 
-if(BUILD_TESTING)
-  find_package(ament_lint_auto REQUIRED)
-  set(ament_cmake_cpplint_FOUND TRUE) # Conflicts with clang-foramt
-  set(ament_cmake_flake8_FOUND TRUE) # Conflicts with black
-  set(ament_cmake_uncrustify_FOUND TRUE) # Conflicts with clang-format
-  ament_lint_auto_find_test_dependencies()
-endif()
-
 ament_package(
   CONFIG_EXTRAS "generate_parameter_library-extras.cmake"
 )
diff --git a/generate_parameter_library/package.xml b/generate_parameter_library/package.xml
@@ -26,9 +26,6 @@
   <depend>tcb_span</depend>
   <depend>tl_expected</depend>
 
-  <test_depend>ament_lint_auto</test_depend>
-  <test_depend>ament_lint_common</test_depend>
-
   <export>
     <build_type>ament_cmake</build_type>
   </export>
diff --git a/generate_parameter_library_py/package.xml b/generate_parameter_library_py/package.xml
@@ -17,7 +17,6 @@
   <depend>python3-typeguard</depend>
   <depend>python3-yaml</depend>
 
-  <test_depend>ament_copyright</test_depend>
   <test_depend>python3-pytest</test_depend>
 
   <export>
diff --git a/generate_parameter_library_py/test/test_copyright.py b/generate_parameter_library_py/test/test_copyright.py
diff --git a/parameter_traits/CMakeLists.txt b/parameter_traits/CMakeLists.txt
@@ -23,14 +23,6 @@ target_link_libraries(parameter_traits
     tl_expected::tl_expected
 )
 
-if(BUILD_TESTING)
-  find_package(ament_lint_auto REQUIRED)
-  # the following lines skip linters
-  set(ament_cmake_cpplint_FOUND TRUE) # Conflicts with clang-foramt
-  set(ament_cmake_uncrustify_FOUND TRUE) # Conflicts with clang-format
-  ament_lint_auto_find_test_dependencies()
-endif()
-
 install(
   DIRECTORY include/
   DESTINATION include/parameter_traits
diff --git a/parameter_traits/package.xml b/parameter_traits/package.xml
@@ -20,8 +20,6 @@
   <depend>tl_expected</depend>
 
   <test_depend>ament_cmake_gtest</test_depend>
-  <test_depend>ament_lint_auto</test_depend>
-  <test_depend>ament_lint_common</test_depend>
 
   <export>
     <build_type>ament_cmake</build_type>
