Fix pre-commit and update clang format to match cpplint

Author: christophfroehlich

.clang-format

@@ -1,17 +1,6 @@
 ---
 BasedOnStyle:  Google
 DerivePointerAlignment: false
-IncludeBlocks: Regroup
-IncludeCategories:
-  # Headers in "" with extension.
-  - Regex:  '"([A-Za-z0-9.\Q/-_\E])+"'
-    Priority: 1
-  # Headers in <> without extension.
-  - Regex:  '<([A-Za-z0-9\Q/-_\E])+>'
-    Priority: 2
-  # Headers in <> from specific external libraries.
-  - Regex:  '<(catch2|boost|rclcpp.*)\/'
-    Priority: 3
-  # Headers in <> with extension.
-  - Regex:  '<([A-Za-z0-9.\Q/-_\E])+>'
-    Priority: 4
+IncludeBlocks: Preserve
+InsertBraces: true
+---

example/include/generate_parameter_library_example/example_validators.hpp

@@ -30,9 +30,9 @@
 
 #include <string>
 
-#include <rclcpp/rclcpp.hpp>
-
 #include <fmt/core.h>
+
+#include <rclcpp/rclcpp.hpp>
 #include <tl_expected/expected.hpp>
 
 namespace custom_validators {

example/include/generate_parameter_library_example/minimal_publisher.hpp

@@ -28,6 +28,8 @@
 
 #pragma once
 
+#include <memory>
+
 #include <rclcpp/rclcpp.hpp>
 #include <rclcpp_components/register_node_macro.hpp>
 
@@ -37,7 +39,8 @@ namespace admittance_controller {
 
 class MinimalPublisher : public rclcpp::Node {
  public:
-  MinimalPublisher(const rclcpp::NodeOptions& options = rclcpp::NodeOptions());
+  explicit MinimalPublisher(
+      const rclcpp::NodeOptions& options = rclcpp::NodeOptions());
 
  private:
   void timer_callback();

example/test/descriptor_test_gtest.cpp

@@ -29,13 +29,13 @@
 // Author: Chance Cardona
 //
 
+#include <limits>
+#include <memory>
+
 #include "generate_parameter_library_example/admittance_controller_parameters.hpp"
 #include "gtest/gtest.h"
 #include "rclcpp/rclcpp.hpp"
 
-#include <limits>
-#include <memory>
-
 class DescriptorTest : public ::testing::Test {
  public:
   void SetUp() {

example/test/example_test_gmock.cpp

@@ -29,12 +29,12 @@
 // Author: Denis Štogl
 //
 
+#include <memory>
+
 #include "generate_parameter_library_example/admittance_controller_parameters.hpp"
 #include "gmock/gmock.h"
 #include "rclcpp/rclcpp.hpp"
 
-#include <memory>
-
 class ExampleTest : public ::testing::Test {
  public:
   void SetUp() {

example/test/example_test_gtest.cpp

@@ -29,12 +29,12 @@
 // Author: Denis Štogl
 //
 
+#include <memory>
+
 #include "generate_parameter_library_example/admittance_controller_parameters.hpp"
 #include "gtest/gtest.h"
 #include "rclcpp/rclcpp.hpp"
 
-#include <memory>
-
 class ExampleTest : public ::testing::Test {
  public:
   void SetUp() {

example_python/setup.py

@@ -1,3 +1,33 @@
+#!/usr/bin/env python3
+
+# Copyright 2023 PickNik Inc.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+#    * Redistributions of source code must retain the above copyright
+#      notice, this list of conditions and the following disclaimer.
+#
+#    * Redistributions in binary form must reproduce the above copyright
+#      notice, this list of conditions and the following disclaimer in the
+#      documentation and/or other materials provided with the distribution.
+#
+#    * Neither the name of the PickNik Inc. nor the names of its
+#      contributors may be used to endorse or promote products derived from
+#      this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
+# LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+# POSSIBILITY OF SUCH DAMAGE.
+
 import sys
 
 from setuptools import setup

example_python/test/test_load_modules.py

@@ -1,3 +1,33 @@
+#!/usr/bin/env python3
+
+# Copyright 2023 PickNik Inc.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+#    * Redistributions of source code must retain the above copyright
+#      notice, this list of conditions and the following disclaimer.
+#
+#    * Redistributions in binary form must reproduce the above copyright
+#      notice, this list of conditions and the following disclaimer in the
+#      documentation and/or other materials provided with the distribution.
+#
+#    * Neither the name of the PickNik Inc. nor the names of its
+#      contributors may be used to endorse or promote products derived from
+#      this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
+# LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+# POSSIBILITY OF SUCH DAMAGE.
+
 import generate_parameter_module_example
 
 print(f'Imported module from: {generate_parameter_module_example.__file__}')

generate_parameter_library_py/setup.py

@@ -1,3 +1,33 @@
+#!/usr/bin/env python3
+
+# Copyright 2023 PickNik Inc.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+#    * Redistributions of source code must retain the above copyright
+#      notice, this list of conditions and the following disclaimer.
+#
+#    * Redistributions in binary form must reproduce the above copyright
+#      notice, this list of conditions and the following disclaimer in the
+#      documentation and/or other materials provided with the distribution.
+#
+#    * Neither the name of the PickNik Inc. nor the names of its
+#      contributors may be used to endorse or promote products derived from
+#      this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
+# LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+# POSSIBILITY OF SUCH DAMAGE.
+
 from setuptools import find_packages
 from setuptools import setup
 

parameter_traits/include/parameter_traits/parameter_traits.hpp

@@ -29,6 +29,10 @@
 #pragma once
 
 #include <fmt/core.h>
+
+#include <string>
+#include <vector>
+
 #include <rsl/algorithm.hpp>
 #include <tl_expected/expected.hpp>