Merge pull request space-ros#317 from space-ros/add-shellcheck

add shellcheck from our new lint action (space-ros#80)

Author: EzraBrooks

.github/workflows/pr.yaml

@@ -4,7 +4,7 @@ name: ROS 2 Repos Check
 on:
   pull_request:
     branches:
-      - '*'
+      - "*"
 
 jobs:
   format_and_validity:
@@ -23,6 +23,13 @@ jobs:
       - name: Validate repositories
         run: vcs validate --input ros2.repos
 
+  lint:
+    name: Space ROS Lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: space-ros/space-ros-lint-action@main
+
   commit_message_standards:
     name: Space ROS Commit Message Standards
     runs-on: ubuntu-latest

docker/entrypoint.sh

@@ -1,6 +1,9 @@
 #!/bin/bash
 
 # Setup the Space ROS environment
+
+# Tell shellcheck to ignore generated file from ROS build scripts
+# shellcheck source=/dev/null
 source "${SPACEROS_DIR}/setup.bash"
 
 exec "$@"

run.sh

@@ -17,7 +17,7 @@ docker run \
   --rm \
   -it \
   --network host \
-  --name ${CONTAINER_NAME} \
+  --name "${CONTAINER_NAME}" \
   -e DISPLAY \
   -e TERM \
   -e QT_X11_NO_MITSHM=1 \