Skip to content

Suppress various SonarCloud violations#1764

Merged
Stephan202 merged 1 commit intomasterfrom
sschroevers/suppress-sonarcloud-violations
Jul 18, 2025
Merged

Suppress various SonarCloud violations#1764
Stephan202 merged 1 commit intomasterfrom
sschroevers/suppress-sonarcloud-violations

Conversation

@Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Jul 16, 2025 •
edited
Loading

This resolves two new issues flagged after #1755, plus some other things. (The SonarCloud analysis currently doesn't run for PRs based off forks.)

Suggested commit message:

Suppress various SonarCloud violations (#1764)

@Stephan202 Stephan202 added this to the 0.24.0 milestone Jul 16, 2025
@Stephan202 Stephan202 added the chore A task not related to code (build, formatting, process, ...) label Jul 16, 2025
@github-actions
Copy link

github-actions bot commented Jul 16, 2025

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202
Copy link
Member Author

Stephan202 commented Jul 16, 2025

Harden-Runner blocked a bunch of new outbound connections, most/all related to Windows Defender. Let's see whether this was a one-off, or whether it persists.
image

@varunsh-coder
Copy link

varunsh-coder commented Jul 16, 2025

We are seeing unexpected calls to *.microsoft.com from GitHub-hosted runners. Seems like some new background service on the runners. We have reached out to GitHub support for confirmation.

mohamedsamehsalah
mohamedsamehsalah approved these changes Jul 17, 2025
View reviewed changes
Copy link
Collaborator

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☢️

@Stephan202 Stephan202 force-pushed the sschroevers/suppress-sonarcloud-violations branch from 2a6c6cc to 193d671 Compare July 18, 2025 17:06
@github-actions
Copy link

github-actions bot commented Jul 18, 2025

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 18, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Stephan202
Copy link
Member Author

Stephan202 commented Jul 18, 2025

As the issue didn't recur, I'll merge the PR.

@Stephan202 Stephan202 merged commit f5c2943 into master Jul 18, 2025
17 checks passed
@Stephan202 Stephan202 deleted the sschroevers/suppress-sonarcloud-violations branch July 18, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickie rickie rickie approved these changes

@mohamedsamehsalah mohamedsamehsalah mohamedsamehsalah approved these changes

Assignees

No one assigned

Labels

chore A task not related to code (build, formatting, process, ...)

Milestone

0.24.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Stephan202 @varunsh-coder @rickie @mohamedsamehsalah