Skip to content

Suppress various SonarCloud violations #1764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stephan202 merged 1 commit into from
Jul 18, 2025
Merged

Suppress various SonarCloud violations #1764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...r-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/CharSequenceRules.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ private CharSequenceRules() {}
// below.
static final class CharSequenceIsEmpty {
@BeforeTemplate
@SuppressWarnings("java:S7158" /* This violation will be rewritten. */)
boolean before(CharSequence charSequence) {
return Refaster.anyOf(
charSequence.length() == 0, charSequence.length() <= 0, charSequence.length() < 1);
Expand Down
5 changes: 3 additions & 2 deletions ...-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/PreconditionsRules.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import com.google.errorprone.refaster.annotation.BeforeTemplate;
import com.google.errorprone.refaster.annotation.UseImportPolicy;
import java.util.Objects;
import org.jspecify.annotations.Nullable;
import tech.picnic.errorprone.refaster.annotation.OnlineDocumentation;

/** Refaster templates related to statements dealing with {@link Preconditions}. */
Expand Down Expand Up @@ -89,7 +90,7 @@ T after(T object) {
}

/** Prefer {@link Objects#requireNonNull(Object)} over more verbose alternatives. */
static final class RequireNonNullStatement<T> {
static final class RequireNonNullStatement<T extends @Nullable Object> {
@BeforeTemplate
@SuppressWarnings("java:S1695" /* This violation will be rewritten. */)
void before(T object) {
Expand Down Expand Up @@ -120,7 +121,7 @@ T after(T object, String message) {
}

/** Prefer {@link Objects#requireNonNull(Object, String)} over more verbose alternatives. */
static final class RequireNonNullWithMessageStatement<T> {
static final class RequireNonNullWithMessageStatement<T extends @Nullable Object> {
@BeforeTemplate
@SuppressWarnings("java:S1695" /* This violation will be rewritten. */)
void before(T object, String message) {
Expand Down
8 changes: 7 additions & 1 deletion error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/StringRules.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ private StringRules() {}
*/
static final class EmptyString {
@BeforeTemplate
@SuppressWarnings("java:S2129" /* This violation will be rewritten. */)
String before() {
return Refaster.anyOf(
new String(),
Expand All @@ -54,6 +55,7 @@ String after() {
// instead of this Refaster rule.
static final class StringIdentity {
@BeforeTemplate
@SuppressWarnings("java:S2129" /* This violation will be rewritten. */)
String before(String str) {
return new String(str);
}
Expand All @@ -72,7 +74,11 @@ String after(String str) {
// rule selection based on some annotation, or a separate Maven module.
static final class StringIsEmpty {
@BeforeTemplate
@SuppressWarnings("CharSequenceIsEmpty" /* This is a more specific template. */)
@SuppressWarnings({
"CharSequenceIsEmpty" /* This is a more specific template. */,
"java:S7158" /* This violation will be rewritten. */,
"key-to-resolve-AnnotationUseStyle-and-TrailingComment-check-conflict"
})
boolean before(String str) {
return Refaster.anyOf(str.length() == 0, str.length() <= 0, str.length() < 1);
}
Expand Down
Loading