Implemented playlists #460 #887#1006
Implemented playlists #460 #887#1006reactormonk wants to merge 9 commits intoPierfrancescoSoffritti:devfrom
Conversation
PierfrancescoSoffritti
left a comment
PierfrancescoSoffritti
left a comment
There was a problem hiding this comment.
I did a first pass, will look more in details after comments are addressed.
| YouTubePlayerBridge.sendPlaylistIndex(index); | ||
| } | ||
|
|
||
| function cuePlaylistObj(obj) { |
There was a problem hiding this comment.
Why do we need a separate method from cuePlaylist? I think we can do without this one.
There was a problem hiding this comment.
They mirror the two ways you can cue playlists according to the API. https://developers.google.com/youtube/iframe_api_reference#Queueing_Functions_for_Playlists
|
|
||
| function cuePlaylist(videos, index, startSeconds) { | ||
| player.cuePlaylist(videos, index, startSeconds); | ||
| YouTubePlayerBridge.sendVideoId(videos[index]); |
There was a problem hiding this comment.
Why are sendVideoId, sendVideoList and sendPlaylistIndex three separate methods? they seem to be called always together. I think we should have single method like updatePlaylist that takes multiple arguments.
There was a problem hiding this comment.
https://github.com/PierfrancescoSoffritti/android-youtube-player/pull/1006/files can only handle a single string, so I wasn't sure if I should serialize the arguments & deserialize again. I figured this would be simpler.
| YouTubePlayerBridge.sendPlaylistIndex(index); | ||
| } | ||
|
|
||
| function loadPlaylistObj(obj) { |
There was a problem hiding this comment.
Same as above, why do we need the obj method?
| */ | ||
| fun cueVideo(videoId: String, startSeconds: Float) | ||
|
|
||
| fun loadPlaylist(videos: List<String>, index: Int, startSeconds: Float) |
There was a problem hiding this comment.
Please, improve existing documentation and add it where it's missing.
Describe what the method is for and all the params.
|
Thank you for the PR, I have left a few comments. |
|
When will this code be available in the library. Version 12.0.0. still not supporting this. Please add it sooner |
|
Hi, I was looking at this again, I was testing the I decide to implement basic playlist controls separately as I understand they are quite important. I will need to come back to this pull request to understand exactly how the cue and load playlist methods fit in. I am sorry for taking so long to get to this, between work and other stuff time is hard to find :) |
|
Thank you, PierfrancescoSoffritti. We made a free Christian radio app that is not working now. Your library is the only chance to make it work again. Will be waiting, You're doing a good job. |
3 participants
I think I got almost everything. Maybe I'll get to the chromecast part.
Implements #460 #887