Conversation
trying to fix issue 1480
Scores don't upload quickly, so this appears to fix the issue. Also ran lint.
|
Hey @varCepheid, usually the scheduled match time and the predicted match time are wrong by 5-10 minutes. Do you think that instead of this solution we could show "upcoming matches" as 2-3 matches? |
… before and three after the current time; in fixing some aestethic issues a couple more popped up, but I don't know exactly how to fix those (and they're a bit less noticeable)
|
I think the problem has been solved, though a bit of tweaking may be useful so that it looks neat (the Upcoming Matches header is off-center, even though it says justify-self: center; and the search bar sits right on top of Qual 1). |
|
Hey @ev118, thanks for updating this! I think there are several opportunities to simplify the approach here, would you be open to scheduling a meeting this weekend to work through that with me? |
…real events so it needs checking. --Elijah
varCepheid
added
bug
…regrine-frontend into fixing-next-match
calebeby
added
the
needs work
|
@varCepheid I also noticed that the issue #1493 is kind of vague and doesn't mention whether it is talking about the next match feature on the team@event page or on the event page. This PR only fixes the team@event page, so maybe we should leave that issue open when this is merged and open another PR for the event page. |
removed "No Upcoming Matches" on event-team page added space below header changed getUpcomingMatches to new series of filters
|
I agree that the issue is vague. I added a description on the PR, which is hopefully more clear. And the changes here do affect the event page; if it wasn't doing anything different, we should definitely fix that here. |
varCepheid
removed
the
needs work
|
When I merged from |
|
@varCepheid sorry for not getting back to you sooner. You shouldn't ever need to manually merge a |
|
Is there anything else that you need to review, or is this ready to push? |
There was a problem hiding this comment.
Looks good just left some comments about the eslint-disable comments. Feel free to merge after addressing those.
I've not done recent testing on this but I trust that you have. Since there are not any TBA events happening right now (other than bunnybots which doesn't have a schedule) you can probably test this by replacing the current time in the code with a fake time from the past to see if it behaves correctly.
* updated comment-card max width trying to fix issue 1480 * changed "next match" to be based on time Scores don't upload quickly, so this appears to fix the issue. Also ran lint. * the problem has been solved, it now shows five matches, in theory two before and three after the current time; in fixing some aestethic issues a couple more popped up, but I don't know exactly how to fix those (and they're a bit less noticeable) * [WIP] change implementation and fix some CSS bugs * [WIP] formatting changes on event-team pages. I couldn't test on any real events so it needs checking. --Elijah * testing with manual date/time * same * testing changes * same * testing is hard * removed score check for upcoming matches function * changed time span for upcoming-matches * changed times again * more testing for upcoming matches * reverted testing changes * removed comments * requested edits removed "No Upcoming Matches" on event-team page added space below header changed getUpcomingMatches to new series of filters * Revert changes to `package-lock.json` * undo unrelated changes --------- Co-authored-by: ev118 <92764232+ev118@users.noreply.github.com> Co-authored-by: Caleb Eby <caleb.eby01@gmail.com>
3 participants
closes #1493
At the top of the event and event-team pages, instead of one "next match," the page shows the three most relevant upcoming matches.