Merged
Conversation
* added checkmarks to match cards on event and event-team-matches pages * enabled checkmarks on event-match page * changed checkmarks to gray
* create alphabetical sorting function for realms dropdown * made get-realms sort the realms, removed sorting from signup * lint
resolve conflicts between dev and main
calebeby
previously approved these changes
Feb 18, 2025
* updated comment-card max width trying to fix issue 1480 * changed "next match" to be based on time Scores don't upload quickly, so this appears to fix the issue. Also ran lint. * the problem has been solved, it now shows five matches, in theory two before and three after the current time; in fixing some aestethic issues a couple more popped up, but I don't know exactly how to fix those (and they're a bit less noticeable) * [WIP] change implementation and fix some CSS bugs * [WIP] formatting changes on event-team pages. I couldn't test on any real events so it needs checking. --Elijah * testing with manual date/time * same * testing changes * same * testing is hard * removed score check for upcoming matches function * changed time span for upcoming-matches * changed times again * more testing for upcoming matches * reverted testing changes * removed comments * requested edits removed "No Upcoming Matches" on event-team page added space below header changed getUpcomingMatches to new series of filters * Revert changes to `package-lock.json` * undo unrelated changes --------- Co-authored-by: ev118 <92764232+ev118@users.noreply.github.com> Co-authored-by: Caleb Eby <caleb.eby01@gmail.com>
calebeby
approved these changes
Feb 18, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.