Skip to content

Add support for binary and hex files #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for binary and hex files #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion android/src/main/java/com/pilloxa/dfu/RNNordicDfuModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,13 @@ public void startDFU(String address, String name, String filePath, Promise promi
starter.setDeviceName(name);
}
starter.setUnsafeExperimentalButtonlessServiceInSecureDfuEnabled(true);
starter.setZip(filePath);

if (filePath.endsWith(".bin") || filePath.endsWith(".hex")) {
starter.setBinOrHex(DfuBaseService.TYPE_APPLICATION, filePath).setInitFile(null, null);
} else {
starter.setZip(filePath);
}

final DfuServiceController controller = starter.start(this.reactContext, DfuService.class);
}

Expand Down
11 changes: 9 additions & 2 deletions ios/RNNordicDfu.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,10 +213,17 @@ - (void)logWith:(enum LogLevel)level message:(NSString * _Nonnull)message
reject(@"unable_to_find_device", @"Could not find device with deviceAddress", nil);
} else {
CBPeripheral * peripheral = [peripherals objectAtIndex:0];
DFUFirmware * firmware;

NSURL * url = [NSURL URLWithString:filePath];

DFUFirmware * firmware = [[DFUFirmware alloc] initWithUrlToZipFile:url];
NSString * extension = [url pathExtension];

if (([extension caseInsensitiveCompare:@"bin"] == NSOrderedSame) ||
([extension caseInsensitiveCompare:@"hex"] == NSOrderedSame)) {
firmware = [[DFUFirmware alloc] initWithUrlToBinOrHexFile:url urlToDatFile:nil type:4];
} else {
firmware = [[DFUFirmware alloc] initWithUrlToZipFile:url];
}

DFUServiceInitiator * initiator = [[[DFUServiceInitiator alloc]
initWithCentralManager:centralManager
Expand Down