Skip to content

Feat: 개발 QA 1차(랜딩페이지 디테일 수정) #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjangminii merged 4 commits into from
Sep 19, 2025
Merged

Feat: 개발 QA 1차(랜딩페이지 디테일 수정) #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
489da8d
feat: 오타 수정
jjangminii Sep 19, 2025
5811865
feat: 헤더 추가
jjangminii Sep 19, 2025
bd15af0
feat: 메타데이터 수정
jjangminii Sep 19, 2025
a6ccaa2
feat: 파비콘 변경
jjangminii Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion apps/client/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@
<html lang="en">
<head>
<meta charset="UTF-8" />
<link rel="icon" type="image/svg+xml" href="/vite.svg" />
<link
rel="icon"
type="image/svg+xml"
href="./public/chippi_extension_popup.svg"
/>
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Pinback</title>
</head>
Expand Down
9 changes: 9 additions & 0 deletions apps/client/public/chippi_extension_popup.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 6 additions & 2 deletions apps/landing/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,13 @@
<html lang="en">
<head>
<meta charset="UTF-8" />
<link rel="icon" type="image/svg+xml" href="/vite.svg" />
<link
rel="icon"
type="image/svg+xml"
href="./public/chippi_extension_popup.svg"
/>
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Vite + React + TS</title>
<title>Pinback</title>
</head>
<body>
<div id="root"></div>
Expand Down
9 changes: 9 additions & 0 deletions apps/landing/public/chippi_extension_popup.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion apps/landing/public/vite.svg
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion apps/landing/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,12 @@ import FeatureBookmarkSection from './components/FeatureBookmarkSection';
import FeatureReminderSection from './components/FeatureReminderSection';
import FeatureRewardSection from './components/FeatureRewardSection';
import FinalCTASection from './components/FinalCTASection';
import Header from './components/Header';

function App() {
return (
<div className="h-dvh snap-y snap-mandatory overflow-y-scroll scroll-smooth">
{/* <Header /> */}
<Header />

{/* 각 섹션들 */}
<section className="h-dvh snap-start">
Expand Down
15 changes: 15 additions & 0 deletions apps/landing/src/components/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import { Icon } from '@pinback/design-system/icons';
import { Button } from '@pinback/design-system/ui';

const Header = () => {
return (
<header className="fixed left-0 right-0 top-0 z-50 flex h-[7.4rem] w-full items-center justify-between px-[8rem]">
Copy link

@coderabbitai coderabbitai bot Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

모바일에서 좌우 패딩 과다로 레이아웃 깨짐 가능

px-[8rem](128px)은 작은 뷰포트에서 요소가 겹치거나 넘칠 수 있습니다. 반응형 패딩으로 조정하세요.

-    <header className="fixed left-0 right-0 top-0 z-50 flex h-[7.4rem] w-full items-center justify-between px-[8rem]">
+    <header className="fixed left-0 right-0 top-0 z-50 flex h-[7.4rem] w-full items-center justify-between px-4 md:px-8">
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<header className="fixed left-0 right-0 top-0 z-50 flex h-[7.4rem] w-full items-center justify-between px-[8rem]">
<header className="fixed left-0 right-0 top-0 z-50 flex h-[7.4rem] w-full items-center justify-between px-4 md:px-8">
🤖 Prompt for AI Agents 
In apps/landing/src/components/Header.tsx around line 6 the header uses a fixed
large horizontal padding `px-[8rem]` which can break layout on small viewports;
replace the hardcoded padding with responsive utility classes (e.g., small fixed
padding on mobile and progressively larger paddings on wider breakpoints) or use
a centered container with responsive horizontal padding (container/mx-auto +
responsive px) so the header no longer overflows on mobile.

<Icon name={'logo'} width={87} height={24} />
<div>
{/*TODO: onClick 추가 */}
<Button>다운로드</Button>
</div>
</header>
);
};
export default Header;
3 changes: 1 addition & 2 deletions apps/landing/src/components/HeroSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ const HeroSection = () => {

return (
<section className="bg-white-bg flex h-dvh w-full flex-col items-center justify-center px-[17.2rem] text-center">
{/* 텍스트 오버레이 */}
<div className="flex flex-col items-center justify-center">
<div className="flex flex-row flex-nowrap items-end justify-center gap-[3rem]">
<img src={landing_icon} alt="Landing Icon" />
Expand Down Expand Up @@ -56,7 +55,7 @@ const HeroSection = () => {
?.scrollIntoView({ behavior: 'smooth' });
}}
>
스트롤하기
스크롤하기
</Button>
</div>
</div>
Expand Down
Loading