Skip to content

tici: increase timeout, and resource for e2e test #4164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CalvinNeo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tici: increase timeout, and resource for e2e test #4164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions prow-jobs/pingcap-inc/tici/presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ global_definitions:
skip_if_only_changed: &skip_if_only_changed "(\\.(md|png|jpeg|jpg|gif|svg|pdf|gitignore)|Dockerfile|OWNERS|OWNERS_ALIASES)$"

decoration_config: &decoration_config
timeout: 80m
timeout: 100m
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The PR title suggests the timeout increase is for the e2e test, but this change increases the timeout for all jobs (pull-verify, pull-it, and pull-e2e). A global timeout increase could mask performance regressions in other jobs. It would be better to apply this change only to the pull-e2e job.

You can achieve this by reverting this line to timeout: 80m and adding a specific decoration_config override to the pull-e2e job like this:

      decoration_config:
        <<: *decoration_config
        timeout: 100m

oauth_token_secret:
name: github-token
key: token
Expand Down Expand Up @@ -104,8 +104,8 @@ presubmits:
make ci-e2e
resources:
requests:
cpu: "6"
cpu: "8"
memory: 24Gi
limits:
cpu: "6"
cpu: "8"
memory: 24Gi