Skip to content

fix(prow): normalize goproxy for prow-jobs/pingcap/tidb-engine-ext#4314

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/normalize-proxies-for-tidb-engine-ext
Draft

fix(prow): normalize goproxy for prow-jobs/pingcap/tidb-engine-ext#4314
Copilot wants to merge 2 commits intomainfrom
copilot/normalize-proxies-for-tidb-engine-ext

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 10, 2026

Remove internal goproxy.pingcap.net endpoint from tidb-engine-ext presubmit jobs, replacing it with the official public Go module proxy.

Changes

  • latest-presubmits.yaml / release-6.1-latest-presubmits.yaml
    • Replace internal proxy http://goproxy.pingcap.net,directhttps://proxy.golang.org,direct
    • Fix env var name: GO_PROXYGOPROXY (standard Go env var)
# Before
- name: GO_PROXY
  value: http://goproxy.pingcap.net,direct

# After
- name: GOPROXY
  value: https://proxy.golang.org,direct
Original prompt

This section details on the original issue you should resolve

<issue_title>goproxy: normalize proxies for prow-jobs/pingcap/tidb-engine-ext</issue_title>
<issue_description>Replace internal goproxy endpoints for prow-jobs/pingcap/tidb-engine-ext with official/public proxies.

Acceptance criteria:

  • No internal goproxy endpoints in prow-jobs/pingcap/tidb-engine-ext
  • GOPROXY values set to default or official proxies
    </issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 10, 2026

Hi @Copilot. Thanks for your PR.

I'm waiting for a PingCAP-QE member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the size/XS label Mar 10, 2026
Co-authored-by: wuhuizuo <2574558+wuhuizuo@users.noreply.github.com>
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 10, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from wuhuizuo. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot AI changed the title [WIP] Normalize proxies for prow-jobs/pingcap/tidb-engine-ext fix(prow): normalize goproxy for prow-jobs/pingcap/tidb-engine-ext Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

goproxy: normalize proxies for prow-jobs/pingcap/tidb-engine-ext

2 participants