Skip to content

fix(prow): normalize goproxy for prow-jobs/pingcap/tidb-binlog#4315

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/remove-internal-goproxy-endpoints
Draft

fix(prow): normalize goproxy for prow-jobs/pingcap/tidb-binlog#4315
Copilot wants to merge 2 commits intomainfrom
copilot/remove-internal-goproxy-endpoints

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 10, 2026

All four GO_PROXY entries in prow-jobs/pingcap/tidb-binlog/latest-presubmits.yaml pointed to http://goproxy.apps.svc — an internal Kubernetes cluster-DNS endpoint inaccessible outside the cluster.

Changes

  • prow-jobs/pingcap/tidb-binlog/latest-presubmits.yaml: Replace all occurrences of the internal proxy with the official Go module proxy:
- value: http://goproxy.apps.svc,direct
+ value: https://proxy.golang.org,direct

Affects all four jobs: pull-build, pull-check, pull-unit-test, wip-pull-integration-test.

Original prompt

This section details on the original issue you should resolve

<issue_title>goproxy: normalize proxies for prow-jobs/pingcap/tidb-binlog</issue_title>
<issue_description>Replace internal goproxy endpoints for prow-jobs/pingcap/tidb-binlog with official/public proxies.

Acceptance criteria:

  • No internal goproxy endpoints in prow-jobs/pingcap/tidb-binlog
  • GOPROXY values set to default or official proxies
    </issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 10, 2026

Hi @Copilot. Thanks for your PR.

I'm waiting for a PingCAP-QE member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Co-authored-by: wuhuizuo <2574558+wuhuizuo@users.noreply.github.com>
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 10, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from wuhuizuo. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot AI changed the title [WIP] Normalize proxies for prow-jobs/pingcap/tidb-binlog fix(prow): normalize goproxy for prow-jobs/pingcap/tidb-binlog Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

goproxy: normalize proxies for prow-jobs/pingcap/tidb-binlog

2 participants