Conversation
MedAmineGBerry
had a problem deploying
to
github-pages
GitHub Actions
Failure
Pull Request Test Coverage Report for Build 21393956766Details
💛 - Coveralls |
FlorianWilhelm
left a comment
FlorianWilhelm
left a comment
There was a problem hiding this comment.
Really great job 🤩 The code is much clearer and I like the short and concise functions! Also great to have a README with it. I just added a few minor comments. Feel free to merge then.
There was a problem hiding this comment.
Really cool idea with having all this in various configs. I just wonder if it would be better to have one file directly in the notebook folder which combines those two? Could be even easier? Just an idea. This also works and is fine.
There was a problem hiding this comment.
Hm... I think precommit was configured to remove the output of all notebooks before a commit. We should do this as this file contains sensitive information like the names. Also the graphics make a huge commit.
| this might have to be updated every year.""" | ||
| data = load_yaml(path) | ||
| mapping: dict[str, str] = {} | ||
| for section in ['general', 'pycon', 'pydata']: |
There was a problem hiding this comment.
Shouldn't the main topics, i.e. general, pycon and pydata, be clear from the structure of the yaml? It feels a bit like double encoding. In the yaml and here. What if there is a typo in the section of the yaml?
| counts = pd.Series(scored).value_counts().reset_index() | ||
| counts.columns = [Col.submission, Col.nreviews] | ||
| else: | ||
| counts = pd.DataFrame({Col.submission: [], Col.nreviews: []}) |
There was a problem hiding this comment.
extra empty line after counts makes it clearer.
| internal_col_map[src] = getattr(Col, dst) | ||
| else: | ||
| internal_col_map[src] = dst | ||
| df = gsheet_df.rename(columns=internal_col_map).copy() |
There was a problem hiding this comment.
Also empty lines after the else clause and before the for. Did you run ruff format?
Maj/review matching new code e82c06c
3 participants
Description
in this PR, I created the new code for the assignement.
we now would have a helpers file containing the functions, a notebook to execute, 2 config files and a readme.
I kept the essence of the notebook as it was, the simple and approachable process as it was built before.
I mainly moved some functions to the helpers, added the readme and created the config file.