fix: roborock.vacuum_goto - command does not exist error#904
Open
matt-d-rat wants to merge 1 commit intoPiotrMachowski:devfrom
Open
fix: roborock.vacuum_goto - command does not exist error#904matt-d-rat wants to merge 1 commit intoPiotrMachowski:devfrom
matt-d-rat wants to merge 1 commit intoPiotrMachowski:devfrom
Conversation
Changes the service call in `vacuum_follow_path` from `roborock.vacuum_goto` to `roborock.set_vacuum_goto_position`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the service call in
vacuum_follow_pathfromroborock.vacuum_gototoroborock.set_vacuum_goto_position, since the former command does not exist (it was renamed in this PR) and is documented here.It's unclear to me whether I need to change any of the service data parameters to ensure that the data is correctly passed to the service as expected. Some guidance here would be appreciated.
Changes need verifying as I do not have an appropriate environment setup to test the changes.
Related issue: #828.