Skip to content

Fix docs v3 redirects #13949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Fix docs v3 redirects #13949

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
faa9c8e
remove docs v3 redirects
andrewjschuang Sep 13, 2024
4c10780
pr comments
andrewjschuang Sep 17, 2024
ae3a319
Merge branch 'master' into docs-remove-v3-redirects
andrewjschuang Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 2 additions & 20 deletions docs-v2/vercel.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
{
"rewrites": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to move these to the redirects section instead of removing them entirely, since we still have some /docs/v3 links out there, so we want to redirect /docs/v3 to /docs

"redirects": [
{
"source": "/docs/v3",
"destination": "/docs"
},
{
"source": "/docs/v3/(.*)",
"destination": "/docs/$1"
}
],
"redirects": [
},
{
"source": "/docs/notebook/actions/",
"destination": "/workflows/steps/actions/"
Expand Down Expand Up @@ -222,14 +220,6 @@
"source": "/docs/components/quickstart/nodejs/actions",
"destination": "/docs/components/actions-quickstart"
},
{
"source": "/docs/components/quickstart/nodejs/sources",
"destination": "/docs/components/sources-quickstart"
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are fine to remove once you have the redirect to handle the root /v3 path

"source": "/docs/v3/components/quickstart/nodejs/sources",
"destination": "/docs/components/sources-quickstart"
},
{
"source": "/docs/github-sync",
"destination": "/docs/quickstart/github-sync"
Expand Down Expand Up @@ -285,14 +275,6 @@
{
"source": "/docs/workflows/networking",
"destination": "/docs/databases#connecting-to-restricted-databases"
},
{
"source": "/docs/errors/",
"destination": "/docs/workflows/errors"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fine to remove

{
"source": "/docs/v3/api/sse",
"destination": "/docs/destinations/sse"
}
]
}
Loading