Skip to content

[Notion] fix for new pages #14125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2024
Merged

[Notion] fix for new pages #14125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa93864
fix: optional chaining
andrewjschuang Sep 27, 2024
923c240
bump versions
andrewjschuang Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/notion/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@pipedream/notion",
"version": "0.1.23",
"version": "0.1.24",
"description": "Pipedream Notion Components",
"main": "notion.app.mjs",
"keywords": [
Expand Down
8 changes: 4 additions & 4 deletions components/notion/sources/updated-page/updated-page.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default {
key: "notion-updated-page",
name: "Updated Page in Database", /* eslint-disable-line pipedream/source-name */
description: "Emit new event when a page in a database is updated. To select a specific page, use `Updated Page ID` instead",
version: "0.0.18",
version: "0.0.19",
type: "source",
dedupe: "unique",
props: {
Expand All @@ -35,8 +35,8 @@ export default {
includeNewPages: {
type: "boolean",
label: "Include New Pages",
description: "Emit events when pages are created or updated. Set to `true` to include newly created pages. Set to `false` to only emit updated pages. Defaults to `false`.",
default: false,
description: "Set to `true` to emit events when pages are created. Set to `false` to ignore new pages.",
default: true,
},
},
hooks: {
Expand Down Expand Up @@ -138,7 +138,7 @@ export default {
let propertyChangeFound = false;
for (const propertyName of properties) {
const hash = this.calculateHash(page.properties[propertyName]);
const dbValue = propertyValues[page.id][propertyName];
const dbValue = propertyValues[page.id]?.[propertyName];
if (!propertyValues[page.id] || hash !== dbValue) {
propertyChangeFound = true;
propertyValues[page.id] = {
Expand Down
Loading