Skip to content

Adding new prop for requestTimeout for Azure SQL #14344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 5, 2024
Merged

Adding new prop for requestTimeout for Azure SQL #14344

merged 4 commits into from
Nov 5, 2024

Conversation

@malexanderlim
Copy link
Contributor

@malexanderlim malexanderlim commented Oct 17, 2024 •
edited
Loading

See example workflow (Test Request Timeout step) for testing the prop.

WHY

Per the feedback here, we should create a requestTimeout prop to make the query timeout window configurable. It used to default to 30s, then we bumped to 60s, but if a user needs to configure this to be longer than 60s, they should be able to for maximum flexibility.

@vercel
Copy link

vercel bot commented Oct 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 8:28pm
pipedream-docs ⬜️ Ignored (Inspect) Oct 17, 2024 8:28pm
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) Oct 17, 2024 8:28pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 17, 2024 •
edited
Loading

Caution

Review failed

The head commit changed during the review from 49dbcd8 to 6ace0ca.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@malexanderlim malexanderlim changed the title Adding new prop for requestTimeout. Adding new prop for requestTimeout for Azure SQL Oct 17, 2024
jcortes
jcortes approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@jcortes jcortes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @malexanderlim lgtm! Ready for QA!

@vunguyenhung
Copy link
Collaborator

vunguyenhung commented Oct 18, 2024 •
edited
Loading

Hi @sergio-eliot-rodriguez @malexanderlim, I'm testing this ticket and can not conenct to the test database Azure SQL in 1PW (host: pipedream-sandbox.database.windows.net)

I've created a VPC with static IP: 54.147.218.229. Would you mind whitelisting this IP in the sandbox Azure SQL when you have time?

Aside from that, I've created a ticket here to allow self-signed cert for local testing: #14349

@malexanderlim
Copy link
Contributor Author

@vunguyenhung , I've added the IP address to the allowlist. Let me know if this works now for you!

@vunguyenhung
Copy link
Collaborator

vunguyenhung commented Oct 21, 2024 •
edited
Loading

Hi @malexanderlim,

I couldn't connect to the sandbox database pipedream-sandbox.database.windows.net using the VPC
image

On another note, when I saved the account and try to fetch the Table, the error indicated that it tries to connect from other IPs such as 3.231.226.21, 18.207.226.160 even though I still selected the VPC 54.147.218.229
image
image

Could you check again when you have time?

@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
https://vunguyenhung.notion.site/Adding-new-prop-for-requestTimeout-for-Azure-SQL-122bf548bb5e81918256ee53a145f236

@malexanderlim malexanderlim merged commit 2fc71ad into master Nov 5, 2024
12 checks passed
@malexanderlim malexanderlim deleted the azure-sql-request-timeout-prop branch November 5, 2024 02:38
lcaresia pushed a commit that referenced this pull request Dec 3, 2024
@malexanderlim @lcaresia
Adding new prop for requestTimeout for Azure SQL (#14344)
d464f21 
* Adding new prop for requestTimeout.

* App file changes and other actions.

* Adding comments back in.

* Version bumps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcortes jcortes jcortes approved these changes

@andrewjschuang andrewjschuang Awaiting requested review from andrewjschuang

Assignees

No one assigned

Labels

None yet

Projects

Component (Source and Action) Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@malexanderlim @vunguyenhung @jcortes