Skip to content

Updating source names for SDK triggers #14638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Updating source names for SDK triggers #14638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions components/sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
{
"name": "@pipedream/sdk",
"version": "0.1.0",
"version": "0.1.1",
"description": "Pipedream SDK Components",
"main": "sdk.app.mjs",
"keywords": [
"pipedream",
"sdk"
"sdk",
"integrations",
"api"
],
"homepage": "https://pipedream.com/apps/sdk",
"homepage": "https://pipedream.com/docs/connect/workflows",
"author": "Pipedream <[email protected]> (https://pipedream.com/)",
"publishConfig": {
"access": "public"
Expand Down
8 changes: 5 additions & 3 deletions components/sdk/sources/nextjs-event-received/nextjs-event-received.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
/* eslint-disable pipedream/source-description */
/* eslint-disable pipedream/source-name */
import sdk from "../../sdk.app.mjs";

export default {
name: "New Event Received from the Next.js Pipedream SDK",
version: "0.0.1",
name: "Next.js",
version: "0.0.2",
key: "sdk-nextjs-event-received",
description: "Emit new event via the Next.js Pipedream SDK.",
description: "Emit a new event via the Next.js Pipedream SDK.",
props: {
sdk,
},
Expand Down
8 changes: 5 additions & 3 deletions components/sdk/sources/nodejs-event-received/nodejs-event-received.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
/* eslint-disable pipedream/source-description */
/* eslint-disable pipedream/source-name */
Comment on lines +1 to +2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Remove unnecessary ESLint disable directives.

The ESLint configuration files were not found, making the ESLint disable directives redundant.

🔗 Analysis chain

Verify if ESLint disable directives are still necessary.

The ESLint directives are disabling rules for source naming and description. Given that this PR is specifically about updating source names, we should verify if these rules are still relevant or if the new changes actually comply with the rules.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for similar ESLint directives across other SDK sources
echo "Checking for ESLint disable patterns across SDK sources..."
rg "eslint-disable.*source-(name|description)" components/sdk/sources/

# Check ESLint configuration for these rules
echo "Checking ESLint rules configuration..."
fd -t f "eslint" -x cat {} \; | rg "source-(name|description)"

Length of output: 1754

Script:

#!/bin/bash
# Locate ESLint configuration files
echo "Locating ESLint configuration files..."
eslint_configs=$(fd -t f -e .eslintrc,.eslintrc.js,.eslintrc.json,.eslintrc.yaml,.eslintrc.yml)

# Check if any ESLint configuration files were found
if [ -z "$eslint_configs" ]; then
  echo "No ESLint configuration files found."
  exit 0
fi

# Search for source-name and source-description rules in ESLint configs
echo "Searching for 'source-name' and 'source-description' rules in ESLint configuration..."
for config in $eslint_configs; do
  echo "Checking in $config..."
  rg '"source-(name|description)"' "$config"
done

Length of output: 293

import sdk from "../../sdk.app.mjs";

export default {
name: "New Event Received from the Node.js Pipedream SDK",
version: "0.0.1",
name: "Node.js",
version: "0.0.2",
key: "sdk-nodejs-event-received",
description: "Emit new event via the Node.js Pipedream SDK.",
description: "Emit a new event via the Node.js Pipedream SDK.",
props: {
sdk,
},
Expand Down
8 changes: 5 additions & 3 deletions components/sdk/sources/nuxtjs-event-received/nuxtjs-event-received.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
/* eslint-disable pipedream/source-description */
/* eslint-disable pipedream/source-name */
import sdk from "../../sdk.app.mjs";

export default {
name: "New Event Received from the Nuxt.js Pipedream SDK",
version: "0.0.1",
name: "NuxtJS",
version: "0.0.2",
key: "sdk-nuxtjs-event-received",
description: "Emit new event via the Nuxt.js Pipedream SDK.",
description: "Emit a new event via the Nuxt.js Pipedream SDK.",
props: {
sdk,
},
Expand Down
8 changes: 5 additions & 3 deletions components/sdk/sources/python-event-received/python-event-received.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
/* eslint-disable pipedream/source-description */
/* eslint-disable pipedream/source-name */
import sdk from "../../sdk.app.mjs";

export default {
name: "New Event Received from the Python Pipedream SDK",
version: "0.0.1",
name: "Python",
version: "0.0.2",
key: "sdk-python-event-received",
description: "Emit new event via the Python Pipedream SDK.",
description: "Emit a new event via the Python Pipedream SDK.",
props: {
sdk,
},
Expand Down
8 changes: 5 additions & 3 deletions components/sdk/sources/reactjs-event-received/reactjs-event-received.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
/* eslint-disable pipedream/source-description */
/* eslint-disable pipedream/source-name */
import sdk from "../../sdk.app.mjs";

export default {
name: "New Event Received from the React.js Pipedream SDK",
version: "0.0.1",
name: "React.js",
version: "0.0.2",
key: "sdk-reactjs-event-received",
description: "Emit new event via the React.js Pipedream SDK.",
description: "Emit a new event via the React.js Pipedream SDK.",
props: {
sdk,
},
Expand Down
8 changes: 5 additions & 3 deletions components/sdk/sources/vue-event-received/vue-event-received.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
/* eslint-disable pipedream/source-description */
/* eslint-disable pipedream/source-name */
Comment on lines +1 to +2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

ESLint suppressions are redundant and can be removed

🔗 Analysis chain

Verify if ESLint suppressions are still needed

Given the simplified name and updated description format, we should verify if these ESLint rule suppressions are still necessary.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check ESLint rules and their purpose

# Search for ESLint rule definitions
rg -A 5 "pipedream/source-(name|description)" .eslintrc*

# Find other source files with similar suppressions
rg "eslint-disable pipedream/source-(name|description)" components/sdk/sources/

Length of output: 1860

import sdk from "../../sdk.app.mjs";

export default {
name: "New Event Received from the Vue Pipedream SDK",
version: "0.0.1",
name: "Vue",
version: "0.0.2",
key: "sdk-vue-event-received",
description: "Emit new event via the Vue Pipedream SDK.",
description: "Emit a new event via the Vue Pipedream SDK.",
props: {
sdk,
},
Expand Down
Loading