feat(sdk-package): call apis directly from client sdk #14699
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import { AsyncResponseManager } from "../shared/async"; | ||
| import type { AsyncResponseManagerOpts } from "../shared/async"; | ||
|
|
||
| export type BrowserAsyncResponseManagerOpts = { | ||
| apiHost: string; | ||
| getConnectToken: () => Promise<string>; | ||
| }; | ||
|
|
||
| export class BrowserAsyncResponseManager extends AsyncResponseManager { | ||
| private browserOpts: BrowserAsyncResponseManagerOpts; | ||
|
|
||
| constructor(opts: BrowserAsyncResponseManagerOpts) { | ||
| super(); | ||
| this.browserOpts = opts; | ||
| } | ||
|
|
||
| protected override async getOpts(): Promise<AsyncResponseManagerOpts> { | ||
| const token = await this.browserOpts.getConnectToken(); | ||
| const url = `wss://${this.browserOpts.apiHost}/websocket?ctok=${token}`; | ||
| return { | ||
| url, | ||
| }; | ||
| } | ||
|
Comment on lines
+17
to
+23
There was a problem hiding this comment. Add error handling and security enhancements The WebSocket URL construction and token handling could benefit from additional security measures and error handling:
Here's a suggested implementation: protected override async getOpts(): Promise<AsyncResponseManagerOpts> {
- const token = await this.browserOpts.getConnectToken();
- const url = `wss://${this.browserOpts.apiHost}/websocket?ctok=${token}`;
+ let token: string;
+ try {
+ token = await this.browserOpts.getConnectToken();
+ if (!token?.trim()) {
+ throw new Error('Invalid token received');
+ }
+ } catch (error) {
+ throw new Error(`Failed to retrieve connect token: ${error.message}`);
+ }
+
+ const url = new URL(`wss://${this.browserOpts.apiHost}/websocket`);
return {
url,
+ headers: {
+ 'Authorization': `Bearer ${token}`
+ }
};
}
|
||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Enhance the deprecation notice with migration guidance
The deprecation notice for the
environmentsproperty should include:Consider updating the changelog entry like this:
📝 Committable suggestion