Skip to content

feat: Update colors for connact-app button #14806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 2, 2024
Merged

feat: Update colors for connact-app button #14806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4e872a0
Update connect app button to use primary theme colors
adolfo-pd Dec 2, 2024
3712994
pnpm-lock
adolfo-pd Dec 2, 2024
8b8d3b0
Bump version
adolfo-pd Dec 2, 2024
ac65745
Merge branch 'master' into money-1945
adolfo-pd Dec 2, 2024
8f954ee
...and Changelog
adolfo-pd Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/connect-react/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
<!-- markdownlint-disable MD024 -->
# Changelog

# [1.0.0-preview.5] - 2024-12-02

- Change colors of "Connect App" button
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Expand the changelog entry with more details

The current changelog entry is too brief. Consider expanding it to include:

  • What specific colors were changed (from/to)
  • The rationale behind the color changes
  • Any potential impact on existing implementations or accessibility

This helps users understand the scope and impact of the changes when upgrading.

Apply this diff to improve the documentation:

-- Change colors of "Connect App" button
+- Change colors of the "Connect App" button to align with theme's primary color scheme:
+  * Updated button colors to use theme.colors.primary25
+  * Improves visual consistency across the application

Committable suggestion skipped: line range outside the PR's diff.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~6-~6: You might be missing the article “the” here.
Context: ...iew.5] - 2024-12-02 - Change colors of "Connect App" button # [1.0.0-preview.4]...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)


# [1.0.0-preview.4] - 2024-11-27

- Fix accidental use of useSuspenseQuery
Expand Down
2 changes: 1 addition & 1 deletion packages/connect-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@pipedream/connect-react",
"version": "1.0.0-preview.4",
"version": "1.0.0-preview.5",
"description": "Pipedream Connect library for React",
"files": [
"dist"
Expand Down
5 changes: 3 additions & 2 deletions packages/connect-react/src/components/ControlApp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,11 @@ export function ControlApp({ app }: ControlAppProps) {
gridArea: "control",
};
const baseStylesConnectButton: CSSProperties = {
backgroundColor: theme.colors.primary,
borderRadius: theme.borderRadius,
border: "solid 1px",
borderColor: theme.colors.neutral20,
color: theme.colors.neutral60,
borderColor: theme.colors.primary25,
color: theme.colors.primary25,
padding: "0.25rem 0.5rem",
gridArea: "control",
};
Expand Down
6 changes: 2 additions & 4 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading