-
Couldn't load subscription status.
- Fork 5.5k
(fix) Fix Nextra v3 upgrade #14865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
(fix) Fix Nextra v3 upgrade #14865
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
b13d961
yak shave
dylburger f19214a
yak shave
dylburger 14052cd
Updating README
dylburger 0820350
Removing docs-v2 lockfiles now that we manage everything in root
dylburger e8abd36
Another try
dylburger 4d366a0
Trying an .npmrc
dylburger feab841
Versions
dylburger 65302c6
Will this work?!
dylburger 114ff4c
fixing pnpm
dylburger f84771c
new lock file
dylburger 9147814
Adding packageManage as per Vercel's instructions
dylburger 1749e65
trying to remove engines to see what breaks
dylburger 464b7bf
Other changes
dylburger 662f25c
Another test
dylburger b16f076
Another try
dylburger 9a877fa
test
dylburger 479a6d5
Another test
dylburger 07d1596
Another test
dylburger fc24293
Again!!
dylburger 0537b5c
BUILD!
dylburger a4e7ba6
Fixing ESLint setup
dylburger 58b32a9
Merge remote-tracking branch 'origin/master' into docs-yak-shave
dylburger fc6455b
lock file
dylburger 0b1ecc4
lock
dylburger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,8 @@ | ||
| auto-install-peers=true | ||
| enable-pre-post-scripts=true | ||
| save-workspace-protocol=false | ||
| link-workspace-packages=false | ||
| link-workspace-packages=false | ||
| shamefully-hoist=true | ||
| node-linker=hoisted | ||
| shared-workspace-lockfile=true | ||
| engine-strict=false |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| auto-install-peers=true | ||
| enable-pre-post-scripts=true | ||
| save-workspace-protocol=false | ||
| link-workspace-packages=false | ||
| shamefully-hoist=true | ||
| node-linker=hoisted | ||
| shared-workspace-lockfile=true | ||
| engine-strict=false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove redundant indexName parameter
The
indexNameis already provided as a top-level prop to the DocSearch component. Adding it again insearchParametersis redundant and potentially confusing.searchParameters={{ facetFilters: [ "version:latest", ], - indexName: process.env.ALGOLIA_INDEX_NAME, }}📝 Committable suggestion