Skip to content

feat: rename Shopify New Shipment trigger and add New Fulfillment Event trigger #14902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: rename Shopify New Shipment trigger and add New Fulfillment Event trigger #14902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions ...ify_developer_app/sources/new-fulfillment-event-created/new-fulfillment-event-created.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
import constants from "../common/constants.mjs";
import common from "../common/webhook-metafields.mjs";

export default {
...common,
key: "shopify_developer_app-new-fulfillment-event-created",
name: "New Fulfillment Event Created (Instant)",
type: "source",
description: "Emit new event when a fulfillment event is created.",
version: "0.0.1",
dedupe: "unique",
methods: {
...common.methods,
getTopic() {
return constants.EVENT_TOPIC.FULFILLMENT_EVENTS_CREATE;
},
generateMeta(resource) {
const ts = Date.parse(resource.created_at);
return {
id: resource.id,
summary: `New Fulfillment Event ${resource.id}`,
ts,
};
},
},
};
10 changes: 5 additions & 5 deletions ...app/sources/new-shipment/new-shipment.mjs → ...rces/new-shipment/new-order-fulfilled.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ import common from "../common/webhook-metafields.mjs";

export default {
...common,
key: "shopify_developer_app-new-shipment",
name: "New Shipment (Instant)",
key: "shopify_developer_app-new-order-fulfilled",
name: "New Order Fulfilled (Instant)",
type: "source",
description: "Emit new event for each new fulfillment event for a store.",
version: "0.0.4",
description: "Emit new event whenever an order is fulfilled.",
version: "0.0.1",
dedupe: "unique",
methods: {
...common.methods,
Expand All @@ -18,7 +18,7 @@ export default {
const ts = Date.parse(resource.updated_at);
return {
id: ts,
summary: `New Shipped Order ${resource.id}.`,
summary: `Order ${resource.id} fulfilled`,
ts,
};
},
Expand Down