Cloudinary usability improvements #15091
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,45 +2,60 @@ import cloudinary from "../../cloudinary.app.mjs"; | |
|
|
||
| export default { | ||
| key: "cloudinary-resource-transformation", | ||
| name: "Transform Video or Audio", | ||
| description: "Transform a video or audio asset on-the-fly with several options. [See the documentation](https://cloudinary.com/documentation/video_manipulation_and_delivery)", | ||
| version: "0.3.0", | ||
| type: "action", | ||
| props: { | ||
| cloudinary, | ||
| assetId: { | ||
| propDefinition: [ | ||
| cloudinary, | ||
| "assetId", | ||
| ], | ||
| }, | ||
| width: { | ||
| type: "integer", | ||
| label: "Width", | ||
| description: "The new width of the video, e.g. `854`", | ||
| optional: true, | ||
| }, | ||
| height: { | ||
| type: "integer", | ||
| label: "Height", | ||
| description: "The new height of the video, e.g. `480`", | ||
| optional: true, | ||
| }, | ||
| duration: { | ||
| type: "integer", | ||
| label: "Duration", | ||
| description: "The duration to set for the video in seconds, e.g. `30`", | ||
| optional: true, | ||
| }, | ||
| transformations: { | ||
| propDefinition: [ | ||
| cloudinary, | ||
| "transformations", | ||
| ], | ||
| }, | ||
| }, | ||
| async run({ $ }) { | ||
| const { | ||
| cloudinary, assetId, transformations, ...options | ||
| } = this; | ||
| try { | ||
| const response = await cloudinary.transformAsset(assetId, { | ||
| ...options, | ||
| ...transformations, | ||
| }); | ||
|
|
||
| if (response) { | ||
| $.export("$summary", "Successfully transformed video"); | ||
| } | ||
|
|
||
| return response; | ||
| } catch (err) { | ||
| throw new Error(`Cloudinary error response: ${err.error?.message ?? JSON.stringify(err)}`); | ||
| } | ||
| }, | ||
| }; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
🛠️ Refactor suggestion
Add metadata property to options object
The review comment is correct. The
metadataproperty is defined in the component's props but not included in the options object passed to the Cloudinary API call. Here are the specific locations that need attention:components/cloudinary/actions/get-resources/get-resources.mjs, add themetadataproperty to the options object in therunmethod:🔗 Analysis chain
Verify metadata property integration with Cloudinary API
The new metadata property is well-documented, but it needs to be included in the options object passed to the Cloudinary API.
Add the metadata property to the options object in the run method:
const options = { resource_type: this.resourceType, type: this.type, prefix: this.prefix, tags: this.tags, context: this.context, moderation: this.moderation, + metadata: this.metadata, };Let me verify if the metadata property is properly integrated with the Cloudinary API by checking the implementation.
Let me fix the regex and try again.
🏁 Scripts executed
The following scripts were executed for the analysis:
Error: No shell scripts found
Script:
Length of output: 190
Script:
Length of output: 674