Skip to content

Biz/dj 2786 fix issue with loading dynamic props #15142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Biz/dj 2786 fix issue with loading dynamic props #15142

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a4661b
Fix issue with loading dynamic props, e.g. google sheets column headers
bzwrk Jan 2, 2025
d6a99e7
Update version
bzwrk Jan 2, 2025
c3219de
Use query input as queryKey for useQuery
bzwrk Jan 3, 2025
3d7a920
Update packages/connect-react/src/hooks/form-context.tsx
bzwrk Jan 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/connect-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@pipedream/connect-react",
"version": "1.0.0-preview.15",
"version": "1.0.0-preview.16",
"description": "Pipedream Connect library for React",
"files": [
"dist"
Expand Down
3 changes: 2 additions & 1 deletion packages/connect-react/src/hooks/form-context.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,12 +129,13 @@
configuredProps,
dynamicPropsId: dynamicProps?.id,
};
const queryKey = reloadPropIdx ? `dynamicProps:${reloadPropIdx}` : "dynamicProps"

Check failure on line 132 in packages/connect-react/src/hooks/form-context.tsx

View workflow job for this annotation

GitHub Actions / Lint Code Base 

Expected newline between test and consequent of ternary expression

Check failure on line 132 in packages/connect-react/src/hooks/form-context.tsx

View workflow job for this annotation

GitHub Actions / Lint Code Base 

Expected newline between consequent and alternate of ternary expression
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Refactor the ternary expression to satisfy lint requirements

Currently, the linter complains about the multiline ternary usage on this line. Splitting the condition, the true branch, and false branch across separate lines will fix the issue:

-const queryKey = reloadPropIdx ? `dynamicProps:${reloadPropIdx}` : "dynamicProps"
+const queryKey = reloadPropIdx
+  ? `dynamicProps:${reloadPropIdx}`
+  : "dynamicProps";
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
const queryKey = reloadPropIdx ? `dynamicProps:${reloadPropIdx}` : "dynamicProps"
const queryKey = reloadPropIdx
? `dynamicProps:${reloadPropIdx}`
: "dynamicProps";
🧰 Tools
🪛 eslint

[error] 132-132132: Expected newline between test and consequent of ternary expression.

(multiline-ternary)

[error] 132-132132: Expected newline between consequent and alternate of ternary expression.

(multiline-ternary)

🪛 GitHub Check: Lint Code Base

[failure] 132-132132:
Expected newline between test and consequent of ternary expression

[failure] 132-132132:
Expected newline between consequent and alternate of ternary expression

🪛 GitHub Actions: Pull Request Checks

[error] 132-132132: Expected newline between test and consequent of ternary expression (multiline-ternary)

const {
isFetching: dynamicPropsQueryIsFetching,
// TODO error
} = useQuery({
queryKey: [
"dynamicProps",
queryKey

Check failure on line 138 in packages/connect-react/src/hooks/form-context.tsx

View workflow job for this annotation

GitHub Actions / Lint Code Base 

Missing trailing comma
],
queryFn: async () => {
const { dynamicProps } = await client.componentReloadProps(componentReloadPropsInput);
Expand Down
Loading