-
Couldn't load subscription status.
- Fork 5.5k
Basecamp usability improvements #15212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
3a770b9
pnpm
GTFalcao ef4fa06
Description standardizing and improvements
GTFalcao 74f2de7
pnpm
GTFalcao 8c192a1
Reusing common props
GTFalcao fd3f7a5
Improvements
GTFalcao cd877c2
More description improvements and standardizing
GTFalcao de4393b
Adjustments
GTFalcao 55779a9
Adjustments
GTFalcao 5bcde2f
API method standardization
GTFalcao e10a9ce
Source description updates and standardization
GTFalcao 253e37a
Reusing common props for sources
GTFalcao 976ad48
Version bump and markdown syntax fixes
GTFalcao c622aff
Summary fix
GTFalcao f5fc900
Adjusting action export
GTFalcao 9c63ee7
Adding card selection to 'create comment'
GTFalcao 82b6da8
Merge branch 'master' into 14975-basecamp-usability-improvements
GTFalcao b6ac56c
pnpm-lock
GTFalcao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,28 +1,14 @@ | ||||||
| import app from "../../basecamp.app.mjs"; | ||||||
| import common from "../../common/common.mjs"; | ||||||
|
|
||||||
| export default { | ||||||
| key: "basecamp-create-card", | ||||||
| name: "Create a Card", | ||||||
| description: "Creates a card in the select column. [See the documentation](https://github.com/basecamp/bc3-api/blob/master/sections/card_table_cards.md#create-a-card)", | ||||||
| description: "Creates a card in a selected column. [See the documentation](https://github.com/basecamp/bc3-api/blob/master/sections/card_table_cards.md#create-a-card)", | ||||||
| type: "action", | ||||||
| version: "0.1.0", | ||||||
| version: "0.1.1", | ||||||
| props: { | ||||||
| app, | ||||||
| accountId: { | ||||||
| propDefinition: [ | ||||||
| app, | ||||||
| "accountId", | ||||||
| ], | ||||||
| }, | ||||||
| projectId: { | ||||||
| propDefinition: [ | ||||||
| app, | ||||||
| "projectId", | ||||||
| ({ accountId }) => ({ | ||||||
| accountId, | ||||||
| }), | ||||||
| ], | ||||||
| }, | ||||||
| ...common.props, | ||||||
| cardTableId: { | ||||||
| propDefinition: [ | ||||||
| app, | ||||||
|
|
@@ -51,25 +37,26 @@ export default { | |||||
| title: { | ||||||
| type: "string", | ||||||
| label: "Title", | ||||||
| description: "Title of the card", | ||||||
| description: "The title of the new card.", | ||||||
| }, | ||||||
| content: { | ||||||
| type: "string", | ||||||
| label: "Content", | ||||||
| description: "Content of the card", | ||||||
| description: "The content of the card. [See the documentation](https://github.com/basecamp/bc3-api/blob/master/sections/card_table_cards.md#create-a-card) for information on using HTML tags.", | ||||||
| optional: true, | ||||||
| }, | ||||||
| dueOn: { | ||||||
| type: "string", | ||||||
| label: "Due on", | ||||||
| description: "Due date (ISO 8601) of the card, e.g.: `2023-12-12`", | ||||||
| label: "Due On", | ||||||
| description: "The due date of the card, in `YYYY-MM-DD` format.", | ||||||
| optional: true, | ||||||
| }, | ||||||
| notify: { | ||||||
| type: "boolean", | ||||||
| label: "Notify", | ||||||
| description: "Whether to notify assignees. Defaults to false", | ||||||
| label: "Notify Assignees", | ||||||
| description: "Whether to notify assignees.", | ||||||
| optional: true, | ||||||
| default: false, | ||||||
| }, | ||||||
| }, | ||||||
| async run({ $ }) { | ||||||
|
|
@@ -96,7 +83,7 @@ export default { | |||||
| }, | ||||||
| }); | ||||||
|
|
||||||
| $.export("$summary", `Successfully created card with ID ${card.id}`); | ||||||
| $.export("$summary", `Successfully created card (ID: ${card.id}}`); | ||||||
|
||||||
| $.export("$summary", `Successfully created card (ID: ${card.id}}`); | |
| $.export("$summary", `Successfully created card (ID: ${card.id})`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catches! Fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix syntax error in summary export
There's a missing closing curly brace in the template literal.
📝 Committable suggestion