Skip to content

Fix toggling optional props in Connect #15231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Fix toggling optional props in Connect #15231

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1003d4
Fix toggling optional props in Connect
jverce Jan 8, 2025
e7cc242
Merge branch 'master' into fix/optional-prop-toggle
jverce Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/connect-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@pipedream/connect-react",
"version": "1.0.0-preview.17",
"version": "1.0.0-preview.18",
"description": "Pipedream Connect library for React",
"files": [
"dist"
Expand Down
5 changes: 5 additions & 0 deletions packages/connect-react/src/hooks/form-context.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,11 @@ export const FormContextProvider = <T extends ConfigurableProps>({
const idx = configurableProps.findIndex((p) => p.name === prop.name);
if (!enabled) {
setConfiguredProp(idx, undefined);
} else if (__configuredProps?.[prop.name as keyof ConfiguredProps<T>] !== undefined) {
setConfiguredProp(
idx,
__configuredProps[prop.name as keyof ConfiguredProps<T>],
);
} else if ("default" in prop && prop.default != null) {
setConfiguredProp(idx, prop.default);
}
Expand Down
8 changes: 4 additions & 4 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading