Skip to content

[Google Sheets] add shared drive prop #15437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 28, 2025
Merged

[Google Sheets] add shared drive prop #15437

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53ced70
add shared drive prop
andrewjschuang Jan 28, 2025
94c250a
bump versions
andrewjschuang Jan 28, 2025
2eb596b
make prop optional
andrewjschuang Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions components/google_sheets/sources/common/http-based/base.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,15 @@ export default {
intervalSeconds: WEBHOOK_SUBSCRIPTION_RENEWAL_SECONDS,
},
},
watchedDrive: {
propDefinition: [
googleSheets,
"watchedDrive",
],
description: "Defaults to My Drive. To select a [Shared Drive](https://support.google.com/a/users/answer/9310351) instead, select it from this list.",
optional: false,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Property definition has inconsistent requirements with base app

The watchedDrive property is marked as required (optional: false) in the Google Sheets source, but it's defined as optional with a default value in the base Google Drive app. This mismatch could cause issues:

  • The base app's implementation assumes the property is optional and provides fallback behavior
  • Making an inherited optional property required could break existing implementations
🔗 Analysis chain

LGTM! Clear and well-documented property definition.

The watchedDrive property is well-defined with:

  • Clear description that includes a helpful documentation link
  • Proper integration with the googleSheets app's propDefinitions
  • Correct requirement setting for this critical configuration

Let's verify that the watchedDrive propDefinition exists in the Google Sheets app:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for the watchedDrive propDefinition in the Google Sheets app
ast-grep --pattern 'propDefinitions: {
  $$$
  watchedDrive: {
    $$$
  },
  $$$
}' components/google_sheets/google_sheets.app.mjs

Length of output: 133

Script:

#!/bin/bash
# First, verify the file exists
ls -l components/google_sheets/google_sheets.app.mjs

# Search for any mention of watchedDrive
rg -l "watchedDrive" components/google_sheets/

# Look for prop definitions in the app file
rg "prop.*Def.*" components/google_sheets/google_sheets.app.mjs

Length of output: 1845

Script:

#!/bin/bash
# Look for googleDrive import in sheets app
rg "import.*googleDrive" components/google_sheets/google_sheets.app.mjs

# Search for watchedDrive in googleDrive component
rg -A 5 "watchedDrive.*:" components/google_drive/ || echo "No matches in google_drive/"

# Verify the inheritance structure
ast-grep --pattern 'export default {
  $$$
  propDefinitions: {
    ...googleDrive.propDefinitions,
    $$$
  },
  $$$
}'  components/google_sheets/google_sheets.app.mjs

Length of output: 60473


sheetID: {
propDefinition: [
googleSheets,
Expand Down
Loading