-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Adding info re: emitting to workflows #15442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe pull request introduces comprehensive updates to the Pipedream Connect API documentation, focusing on enhancing the clarity and functionality of trigger, webhook, and workflow management. The changes provide more detailed instructions for deploying triggers, managing webhook URLs, and configuring workflow interactions. The documentation now offers clearer guidance on how to deploy trigger components, specify webhook and workflow endpoints, and test workflow triggers with specific headers and authentication requirements. Changes
Sequence DiagramsequenceDiagram
participant User
participant PipedreamConnect
participant Trigger
participant Webhook
participant Workflow
User->>PipedreamConnect: Deploy Trigger
PipedreamConnect->>Trigger: Configure Component
User->>PipedreamConnect: Specify Webhook/Workflow URLs
PipedreamConnect->>Trigger: Update Listener Endpoints
Trigger-->>Webhook: Emit Events
Trigger-->>Workflow: Emit Events
Possibly related PRs
Suggested labels
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs-v2/pages/connect/api.mdx (1)
Line range hint
2013-2058: Consider adding a combined webhook and workflow example.The documentation clearly explains both
webhook_urlandworkflow_urlparameters. To make it even more helpful, consider adding a code example that demonstrates how to use both parameters together, showing users how to emit events to both a webhook and a workflow simultaneously.Example addition:
+ Example using both webhook_url and workflow_url: + + ```json + { + "webhook_url": "https://events.example.com/webhook", + "workflow_url": "p_1234567", + "configured_props": { + // ... other properties + } + } + ```🧰 Tools
🪛 LanguageTool
[style] ~2051-~2051: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ... The Pipedream workflow ID to which you want to emit events (ex,p_1234567). <Callou...(REP_WANT_TO_VB)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
docs-v2/pages/connect/api.mdx(3 hunks)docs-v2/pages/connect/workflows.mdx(3 hunks)
🧰 Additional context used
🪛 LanguageTool
docs-v2/pages/connect/api.mdx
[style] ~2051-~2051: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ... The Pipedream workflow ID to which you want to emit events (ex, p_1234567). <Callou...
(REP_WANT_TO_VB)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: pnpm publish
- GitHub Check: Lint Code Base
- GitHub Check: validate-links
🔇 Additional comments (4)
docs-v2/pages/connect/workflows.mdx (4)
41-50: Well-structured instructions for HTTP trigger setup!Clear and accurate documentation of the required headers for test events.
257-264: Clear presentation of workflow triggering options!Well-organized introduction with proper navigation links to detailed subsections.
266-275: Comprehensive prerequisites with security focus!Good emphasis on OAuth client creation as a recommended security practice.
276-353: Excellent code examples with proper environment handling!Well-structured examples in multiple languages with appropriate error handling and authentication flow.
WHY
Summary by CodeRabbit