Shopify - add webhook events #15698
Shopify - add webhook events #15698
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThe pull request updates a constants file by adding a variety of new event topics to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
components/shopify/sources/new-event-emitted/new-event-emitted.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/shopify/sources/new-product-created/new-product-created.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/shopify/sources/common/constants.mjs (1)
89-93: Consider reordering subscription contract events.The new subscription contract event topics are correctly defined but could be better organized. Consider grouping all subscription contract events together.
Apply this diff to improve organization:
- SUBSCRIPTION_CONTRACTS_ACTIVATE: "subscription_contracts/activate", - SUBSCRIPTION_CONTRACTS_CANCEL: "subscription_contracts/cancel", - SUBSCRIPTION_CONTRACTS_EXPIRE: "subscription_contracts/expire", - SUBSCRIPTION_CONTRACTS_FAIL: "subscription_contracts/fail", - SUBSCRIPTION_CONTRACTS_PAUSE: "subscription_contracts/pause", SUBSCRIPTION_CONTRACTS_CREATE: "subscription_contracts/create", + SUBSCRIPTION_CONTRACTS_ACTIVATE: "subscription_contracts/activate", + SUBSCRIPTION_CONTRACTS_CANCEL: "subscription_contracts/cancel", + SUBSCRIPTION_CONTRACTS_EXPIRE: "subscription_contracts/expire", + SUBSCRIPTION_CONTRACTS_FAIL: "subscription_contracts/fail", + SUBSCRIPTION_CONTRACTS_PAUSE: "subscription_contracts/pause", SUBSCRIPTION_CONTRACTS_UPDATE: "subscription_contracts/update",Also applies to: 94-95
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
components/shopify/sources/common/constants.mjs(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: pnpm publish
- GitHub Check: Verify TypeScript components
- GitHub Check: Publish TypeScript components
🔇 Additional comments (9)
components/shopify/sources/common/constants.mjs (9)
10-10: LGTM: App scopes update event added.The new
APP_SCOPES_UPDATEevent topic is correctly placed in alphabetical order and follows the established naming convention.
19-23: LGTM: Discount-related events added.The new discount event topics are well-organized and cover essential discount operations (create, delete, update) and redeem code management.
27-46: LGTM: Comprehensive fulfillment order events added.The new fulfillment order event topics provide extensive coverage of the fulfillment workflow, including:
- Cancellation request lifecycle
- Fulfillment request lifecycle
- Hold management
- Local delivery and pickup preparation
- Order routing and scheduling
58-59: LGTM: Location activation events added.The new location event topics complement the existing location management events by adding activation state changes.
63-63: LGTM: Payment schedule event added.The new payment schedule event topic for due payments is correctly placed and follows the naming convention.
71-78: LGTM: Return management events added.The new return event topics provide comprehensive coverage of the returns workflow, including approval, cancellation, closure, processing, and updates.
82-84: LGTM: Segment management events added.The new segment event topics follow the standard CRUD pattern (create, delete, update) and maintain consistency with other similar event groups.
100-101: LGTM: Variant stock status events added.The new variant event topics for stock status changes are correctly placed and follow the naming convention.
102-102: Consider removing or documenting EVENT_TOPICS_THEMES_UPDATE.The
EVENT_TOPICS_THEMES_UPDATEconstant appears to be out of place:
- It doesn't follow the same naming pattern as other constants (uses hyphens instead of forward slashes)
- Its purpose is unclear compared to the existing
THEMES_UPDATEeventCould you clarify the purpose of this constant and whether it's still needed? If it's deprecated, consider removing it.
WHY
Summary by CodeRabbit
New Features
Chores