Bug Fix - Hubspot New Deal In Stage trigger

[michelle0927]

Resolves #15724

Summary by CodeRabbit

• Chores
  • Updated component versions to mark a new release.
• Refactor
  • Streamlined the deal processing workflow for a more efficient request handling.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	⬜️ Ignored (Inspect)			Feb 24, 2025 8:48pm
pipedream-docs	⬜️ Ignored (Inspect)			Feb 24, 2025 8:48pm
pipedream-docs-redirect-do-not-edit	⬜️ Ignored (Inspect)			Feb 24, 2025 8:48pm

[coderabbitai]

Walkthrough

The pull request makes two primary changes in the HubSpot component. The components/hubspot/package.json file has its version bumped from "1.0.0" to "1.0.1". Additionally, in components/hubspot/sources/new-deal-in-stage/new-deal-in-stage.mjs, the version is updated from "0.0.23" to "0.0.24", and the rate-limiting mechanism in the processDeals method is removed. This results in a more direct call to this.hubspot.searchCRM(params) for processing deals.

Changes

File(s)	Change Summary
components/hubspot/package.json	Updated package version from "1.0.0" to "1.0.1".
components/hubspot/sources/new-deal-in-stage/new-deal-in-stage.mjs	Updated version from "0.0.23" to "0.0.24" and removed the rate limiter in the processDeals method to directly invoke this.hubspot.searchCRM(params).

Sequence Diagram(s)

sequenceDiagram
    participant P as ProcessDeals Method
    participant H as HubSpot CRM
    participant E as Event Emitter

    P->>+H: searchCRM(params)
    H-->>-P: Return deal data
    P->>E: Emit deal event

Loading

Possibly related PRs

• Hubspot - New Custom Object Property Change #14977: Updates package version in components/hubspot/package.json similar to the change made here.
• Hubspot new task version fix #15216: Another instance of a version update in the HubSpot component.
• Hubspot version update #14816: Aligns with the version increment changes in the HubSpot package.

Suggested reviewers

• jcortes

Poem

I'm a rabbit hopping through lines of code,
New versions gleam down every road.
The rate limiter’s gone from my dance,
Now deals leap forward by pure chance.
Hoppy bytes and joyful leaps abound,
As CodeRabbit cheers with a merry sound!
🐰✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

components/hubspot/sources/new-deal-in-stage/new-deal-in-stage.mjs

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at packageResolve (node:internal/modules/esm/resolve:839:9)
at moduleResolve (node:internal/modules/esm/resolve:908:18)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e49a80d and 5e180ea.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (2)

• components/hubspot/package.json (1 hunks)
• components/hubspot/sources/new-deal-in-stage/new-deal-in-stage.mjs (2 hunks)

✅ Files skipped from review due to trivial changes (1)

• components/hubspot/package.json

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: Verify TypeScript components
• GitHub Check: pnpm publish
• GitHub Check: Lint Code Base
• GitHub Check: Publish TypeScript components

🔇 Additional comments (2)

components/hubspot/sources/new-deal-in-stage/new-deal-in-stage.mjs (2)

10-10: LGTM! Version bump is appropriate.

The version increment from "0.0.23" to "0.0.24" aligns with the package version update and follows semantic versioning for bug fixes.

---

90-90:

✅ Verification successful

Verify impact of removing rate limiting.

The rate-limiting mechanism has been removed in favor of direct API calls. While this might fix the reported issue, please verify:

1. That HubSpot's API has built-in rate limiting that makes the custom rate limiter redundant
2. That this change won't cause issues with HubSpot's API quotas

Let's check HubSpot's API documentation for rate limiting details:

---

🌐 Web query:

What are HubSpot's API rate limits for CRM search endpoints?

💡 Result:

HubSpot's CRM Search API has specific rate limits designed to manage request volume and ensure system stability. Based on recent updates:

Rate Limits for CRM Search API

• Burst limit: Increased to 5 requests per second per authentication token[1][6]. This applies to both private and public apps using the CRM Search endpoints[1][9].
• Response size: Supports up to 200 records per response, doubled from the previous 100-record limit[1].

Additional Context

These limits are part of HubSpot's tiered approach to API management:

• The burst limit allows short-term spikes while maintaining overall system performance[7].
• Apps using OAuth have separate limits (100 requests/10 seconds for most APIs), but CRM Search uses its own specific rate limits[9][3].

If you encounter 429 TEN_SECONDLY_ROLLING errors, implement retry mechanisms with exponential backoff or use HubSpot's official client libraries that include built-in rate limiting[2][4]. For high-volume needs, consider HubSpot's API Limit Increase capacity pack which can raise daily request allowances[1].

Citations:

• 1: https://developers.hubspot.com/changelog/increasing-our-api-limits
• 2: https://github.com/HubSpot/hubspot-api-nodejs
• 3: https://community.hubspot.com/t5/APIs-Integrations/Rate-limits-API/m-p/1002704
• 4: https://docs.celigo.com/hc/en-us/community/posts/20280849745947-Hubspot-Rate-limit
• 5: https://support.geckoboard.com/en/articles/8005323-exceeding-hubspot-s-api-request-limit
• 6: https://rollout.com/integration-guides/hubspot/api-essentials
• 7: https://developers.hubspot.com/changelog/crm-search-api-rate-limit-increase
• 8: https://www.getknit.dev/blog/hubspot-api-directory-oD0RSt
• 9: https://community.hubspot.com/t5/APIs-Integrations/Public-APP-API-Limit/m-p/980637
• 10: https://community.qlik.com/t5/Integration-Extension-APIs/Pagination-of-hubspot-deals-API/td-p/1768665

---

Verified: Removal of the custom rate limiter is acceptable given HubSpot's built-in rate limits.

• The direct API call on line 90 in components/hubspot/sources/new-deal-in-stage/new-deal-in-stage.mjs now relies solely on HubSpot’s CRM Search API.
• HubSpot documentation confirms a burst limit of 5 requests per second per authentication token, which should provide sufficient rate control for typical usage.
• Please ensure that your application's call volume remains within this limit. If there's potential for higher traffic, consider adding retry logic (with exponential backoff) to gracefully handle any 429 responses.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[jcortes]

Hi @michelle0927 lgtm! Ready for QA!