Google Calendar - bug fix to new-or-updated-event-instant #15738
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
WalkthroughThis pull request primarily updates version numbers across multiple Google Calendar modules and the package file. In addition, a new constant for webhook subscription renewal has been added to the constants file. One source file ("new-or-updated-event-instant.mjs") also includes modifications to its constant import and enhanced error handling in its Changes
Sequence Diagram(s)sequenceDiagram
participant Caller as Deactivate Caller
participant Module as new-or-updated-event-instant
participant StopWatch as stopWatchRequest
participant Logger as Error Logger
Caller->>Module: Calls deactivate()
Module->>StopWatch: Invokes stopWatchRequest()
alt Successful Execution
StopWatch-->>Module: Returns success
else Error Occurs
StopWatch-->>Module: Throws error
Module->>Logger: Logs error message
end
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
components/google_calendar/actions/add-attendees-to-event/add-attendees-to-event.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/google_calendar/actions/get-event/get-event.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/google_calendar/actions/create-event/create-event.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/google_calendar/sources/new-or-updated-event-instant/new-or-updated-event-instant.mjs (1)
69-73: Improved error handling in the deactivate method.Adding a try-catch block is an important improvement that prevents errors during webhook deactivation from causing issues with the deactivation process. This helps with graceful shutdown even when the webhook deactivation fails.
Consider enhancing the error logging to include more context about what caused the failure:
- console.log(`Error deactivating webhook. ${e}`); + console.log(`Error deactivating webhook for Google Calendar source. Details: ${e.message || e}`);
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (18)
components/google_calendar/actions/add-attendees-to-event/add-attendees-to-event.mjs(1 hunks)components/google_calendar/actions/create-event/create-event.mjs(1 hunks)components/google_calendar/actions/delete-event/delete-event.mjs(1 hunks)components/google_calendar/actions/get-calendar/get-calendar.mjs(1 hunks)components/google_calendar/actions/get-event/get-event.mjs(1 hunks)components/google_calendar/actions/list-calendars/list-calendars.mjs(1 hunks)components/google_calendar/actions/list-events/list-events.mjs(1 hunks)components/google_calendar/actions/query-free-busy-calendars/query-free-busy-calendars.mjs(1 hunks)components/google_calendar/actions/quick-add-event/quick-add-event.mjs(1 hunks)components/google_calendar/actions/update-event/update-event.mjs(1 hunks)components/google_calendar/common/constants.mjs(1 hunks)components/google_calendar/package.json(1 hunks)components/google_calendar/sources/event-cancelled/event-cancelled.mjs(1 hunks)components/google_calendar/sources/event-ended/event-ended.mjs(1 hunks)components/google_calendar/sources/new-calendar/new-calendar.mjs(1 hunks)components/google_calendar/sources/new-event-search/new-event-search.mjs(1 hunks)components/google_calendar/sources/new-or-updated-event-instant/new-or-updated-event-instant.mjs(3 hunks)components/google_calendar/sources/upcoming-event-alert/upcoming-event-alert.mjs(1 hunks)
✅ Files skipped from review due to trivial changes (16)
- components/google_calendar/actions/list-events/list-events.mjs
- components/google_calendar/package.json
- components/google_calendar/sources/event-cancelled/event-cancelled.mjs
- components/google_calendar/actions/update-event/update-event.mjs
- components/google_calendar/actions/create-event/create-event.mjs
- components/google_calendar/actions/query-free-busy-calendars/query-free-busy-calendars.mjs
- components/google_calendar/sources/new-calendar/new-calendar.mjs
- components/google_calendar/actions/add-attendees-to-event/add-attendees-to-event.mjs
- components/google_calendar/sources/event-ended/event-ended.mjs
- components/google_calendar/sources/new-event-search/new-event-search.mjs
- components/google_calendar/actions/quick-add-event/quick-add-event.mjs
- components/google_calendar/actions/get-calendar/get-calendar.mjs
- components/google_calendar/actions/list-calendars/list-calendars.mjs
- components/google_calendar/actions/delete-event/delete-event.mjs
- components/google_calendar/actions/get-event/get-event.mjs
- components/google_calendar/sources/upcoming-event-alert/upcoming-event-alert.mjs
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: pnpm publish
- GitHub Check: Verify TypeScript components
- GitHub Check: Publish TypeScript components
🔇 Additional comments (5)
components/google_calendar/common/constants.mjs (2)
88-90: Good addition of webhook renewal constants.Adding these constants that define webhook subscription expiration time and renewal timing is a good practice. Setting the renewal to 95% of the expiration time provides a proper buffer to ensure subscriptions are renewed before they expire.
95-95: LGTM on exporting the renewal constant.Properly exporting the constant so it can be used in other modules.
components/google_calendar/sources/new-or-updated-event-instant/new-or-updated-event-instant.mjs (3)
4-4: Appropriate import of constants module.Importing the constants module instead of using hardcoded values is a good practice for maintainability.
11-11: Version bump is appropriate.The version increment from 0.1.14 to 0.1.15 is appropriate for this bug fix.
41-41: Good use of the central constant for timer interval.Using the centrally defined constant
WEBHOOK_SUBSCRIPTION_RENEWAL_SECONDSinstead of a hardcoded value makes the code more maintainable.
Resolves #15720
Summary by CodeRabbit