-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Jotform - fix region from auth #15751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request makes minor version updates across several Jotform modules and refactors a method within the Jotform app. Specifically, the version numbers in multiple action, source, and configuration files have been incremented. Additionally, the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant JotformApp
Client->>JotformApp: Request base URL
JotformApp->>JotformApp: Check if $auth.subdomain is defined
alt Subdomain exists
JotformApp->>Client: Return "$auth.subdomain/API/"
else
JotformApp->>Client: Return "$auth.region"
end
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
components/jotform/actions/get-form-submissions/get-form-submissions.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/jotform/actions/get-user-submissions/get-user-submissions.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/jotform/actions/get-monthly-user-usage/get-monthly-user-usage.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
Tip CodeRabbit's docstrings feature is now available as part of our Pro Plan! Simply use the command 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (6)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WHY
Changed how region is inputted from the auth if it's enterprise
Summary by CodeRabbit
Chores
Refactor