[Gmail] fix last date #16205
[Gmail] fix last date #16205
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThis pull request updates the version numbers of several Gmail components and refines the logic within some modules. The updates include version bumps in package metadata and components, adjustments to condition checks within message processing, improved error handling, streamlined method signatures with type annotations, and refined query construction for handling attachments. Changes
Sequence Diagram(s)sequenceDiagram
participant Run as Run Method
participant GM as GetMessageIds
participant Proc as ProcessMessageIds
participant DB as Database
participant Log as Logger
Run->>GM: Retrieve message IDs
alt Message IDs exist
Run->>Log: Log number of messages
Run->>Proc: Process available message IDs
Proc->>DB: Update lastDate (parseInt conversion)
else No message IDs
Note over Run: No further processing
end
sequenceDiagram
participant NA as New Attachment Component
participant QC as Query Constructor
participant CM as Common Methods
NA->>QC: Check for "has:attachment" in query
alt "has:attachment" not present
QC->>QC: Append "has:attachment" to query
end
NA->>CM: Call common constructQuery(lastDate)
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/gmail/sources/common/polling-messages.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/gmail/sources/new-attachment-received/new-attachment-received.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/gmail/sources/new-email-matching-search/new-email-matching-search.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/gmail/sources/common/polling-messages.mjs (1)
26-26: Consider specifying the radix parameter for parseInt.When using
parseInt(), it's a best practice to specify the radix parameter to avoid unexpected behavior with certain inputs.- this.db.set("lastDate", parseInt(lastDate)); + this.db.set("lastDate", parseInt(lastDate, 10));
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (5)
components/gmail/package.json(1 hunks)components/gmail/sources/common/polling-messages.mjs(3 hunks)components/gmail/sources/new-attachment-received/new-attachment-received.mjs(2 hunks)components/gmail/sources/new-email-matching-search/new-email-matching-search.mjs(1 hunks)components/gmail/sources/new-sent-email/new-sent-email.mjs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Verify TypeScript components
- GitHub Check: Publish TypeScript components
🔇 Additional comments (12)
components/gmail/package.json (1)
3-3: Version bump for bug fix implementationThe package version has been updated from 0.2.7 to 0.2.8, which is appropriate for the bug fix related to the last date handling in queries.
components/gmail/sources/new-sent-email/new-sent-email.mjs (1)
9-9: Component version incrementThe component version has been incremented from 0.0.8 to 0.0.9, maintaining consistency with the package version update.
components/gmail/sources/new-email-matching-search/new-email-matching-search.mjs (1)
9-9: Component version incrementThe component version has been incremented from 0.0.7 to 0.0.8, maintaining consistency with the package version update.
components/gmail/sources/new-attachment-received/new-attachment-received.mjs (2)
9-9: Component version incrementThe component version has been incremented from 0.0.9 to 0.0.10, maintaining consistency with the package version update.
33-41: Improved query construction for attachment filteringThe refactored
constructQuerymethod now correctly ensures that "has:attachment" is always included in the query while delegating other aspects of query construction to the common implementation. This is cleaner and more maintainable than the previous implementation.The approach properly handles three cases:
- When
this.qis not set- When
this.qis set but doesn't contain the attachment filter- When
this.qalready contains the attachment filterBy delegating to the common implementation with
call(this, lastDate), it ensures consistent handling of the last date parameter across all components.components/gmail/sources/common/polling-messages.mjs (7)
10-12: Improved condition logic for processing historical events.The switch from a negation check to a positive check makes the code more readable and ensures that historical events are only processed when message IDs actually exist.
31-31: Good use of Math.trunc for timestamp conversion.Using
Math.trunc()instead of simple division ensures that the Unix timestamp is properly formatted without any fractional seconds, which aligns with Gmail's query syntax requirements.
33-38: Improved query construction with added logging.The query construction is now more readable using an array join pattern, and the added logging statement will help with debugging query-related issues.
46-46: Good defensive programming with nullish coalescing operator.Using the nullish coalescing operator (
?? []) ensures that the function always returns an array, even whenmessagesis undefined or null, preventing potential downstream errors.
52-54: Simplified message processing logic.The code now directly emits the event and updates the maxDate without conditional checks, making the logic more straightforward.
55-57: Performance optimization for database updates.Checking if
maxDate !== lastDatebefore callingsetLastDate()prevents unnecessary database operations when the date hasn't changed.
69-72: Enhanced run method with better logging and conditional processing.The improved condition for processing message IDs and the added logging statement provide better visibility into the execution flow. Also, reversing the message IDs ensures they're processed in the correct order (likely newest to oldest).
WHAT
Summary by CodeRabbit
New Features
Bug Fixes
Chores