Skip to content

MCP - improve string and string[] schemas #16361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2025
Merged

MCP - improve string and string[] schemas #16361

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c88dee9
MCP - improve string and string[] schemas
jsendo Apr 18, 2025
0950557
fix spacing
jsendo Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 20 additions & 17 deletions modelcontextprotocol/lib/registerComponentTools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,24 +79,27 @@ export async function registerComponentTools({
appKey = cp.name
continue
} else if (cp.type === "string") {
schema[cp.name] = z.string()
if (
cp.options &&
Array.isArray(cp.options) &&
cp.options.length > 0 &&
cp.options.some((o) => typeof o === "string")
) {
schema[cp.name] = z.enum(cp.options)
} else {
schema[cp.name] = z.string()
}
} else if (cp.type === "string[]") {
schema[cp.name] = z
.union([
z.string().transform((val) => {
try {
return JSON.parse(val)
} catch {
return [
val,
] // If not valid JSON, treat as single item array
}
}),
z.array(z.string()),
])
.refine((val) => Array.isArray(val), {
message: "Must be an array of strings",
})
if (
cp.options &&
Array.isArray(cp.options) &&
cp.options.length > 0 &&
cp.options.some((o) => o.value != null)
) {
schema[cp.name] = z.array(z.enum(cp.options.map((o) => o.value)))
} else {
schema[cp.name] = z.array(z.string())
}
configurablePropsDescription += `- ${cp.name}: Return JSON in this format: string[]\n`
} else if (cp.type === "number") {
schema[cp.name] = z.number()
Expand Down
Loading