add ProxyResponse type, change DEBUG location #16366
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThis update introduces a new Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant BackendClient
participant API
Client->>BackendClient: makeProxyRequest(proxyOptions, targetRequest)
BackendClient->>API: Send proxied API request
API-->>BackendClient: Response (JSON or string)
BackendClient->>Client: Return ProxyResponse (object or string)
Suggested reviewers
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
packages/sdk/CHANGELOG.md(1 hunks)packages/sdk/package.json(1 hunks)packages/sdk/src/server/index.ts(2 hunks)packages/sdk/src/shared/index.ts(1 hunks)
🧰 Additional context used
🪛 GitHub Check: test
packages/sdk/CHANGELOG.md
[failure] 10-10: Line length
packages/sdk/CHANGELOG.md:10:81 MD013/line-length Line length [Expected: 80; Actual: 86] https://github.com/DavidAnson/markdownlint/blob/v0.35.0/doc/md013.md
🪛 GitHub Actions: Lint SDK Markdown Files
packages/sdk/CHANGELOG.md
[error] 10-10: markdownlint MD013/line-length: Line length exceeds 80 characters (Actual: 86). See https://github.com/DavidAnson/markdownlint/blob/v0.35.0/doc/md013.md
🪛 GitHub Actions: Pull Request Checks
packages/sdk/CHANGELOG.md
[warning] 1-1: File ignored because of a matching ignore pattern. Use "--no-ignore" to disable file ignore settings or use "--no-warn-ignored" to suppress this warning.
packages/sdk/src/server/index.ts
[error] 158-158: ESLint: Unexpected any. Specify a different type. (@typescript-eslint/no-explicit-any)
🪛 GitHub Check: Lint Code Base
packages/sdk/src/server/index.ts
[failure] 158-158:
Unexpected any. Specify a different type
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: pnpm publish
- GitHub Check: test
🔇 Additional comments (3)
packages/sdk/package.json (1)
4-4: Version increment looks appropriateThe version bump from 1.5.2 to 1.5.3 follows semantic versioning for the changes made in this PR.
packages/sdk/src/shared/index.ts (1)
1024-1028: Improved debug logging structureSplitting the DEBUG calls into separate statements for status, URL, options, and response body improves visibility and makes the logs more granular. This is a good change that will help with troubleshooting.
packages/sdk/src/server/index.ts (1)
433-433: Return type update for makeProxyRequest is appropriateUpdating the return type of
makeProxyRequestto use the newProxyResponsetype is a good change that properly reflects the method's behavior of returning either a parsed JSON object or a string.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/sdk/CHANGELOG.md(1 hunks)packages/sdk/src/server/index.ts(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- packages/sdk/src/server/index.ts
🧰 Additional context used
🪛 GitHub Check: test
packages/sdk/CHANGELOG.md
[failure] 10-10: Trailing spaces
packages/sdk/CHANGELOG.md:10:75 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1] https://github.com/DavidAnson/markdownlint/blob/v0.35.0/doc/md009.md
[failure] 11-11: Lists should be surrounded by blank lines
packages/sdk/CHANGELOG.md:11 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "error case."] https://github.com/DavidAnson/markdownlint/blob/v0.35.0/doc/md032.md
🪛 GitHub Actions: Lint SDK Markdown Files
packages/sdk/CHANGELOG.md
[error] 10-10: markdownlint MD009/no-trailing-spaces: Trailing spaces detected (Expected: 0 or 2; Actual: 1). See https://github.com/DavidAnson/markdownlint/blob/v0.35.0/doc/md009.md
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Lint Code Base
- GitHub Check: test
🔇 Additional comments (2)
packages/sdk/CHANGELOG.md (2)
5-5: Changelog header updated correctly
Version1.5.3and date2025-04-18follow the existing format and ordering.
9-9: Changelog entry forProxyResponseis clear
The description succinctly captures the new type addition.
packages/sdk/CHANGELOG.md
Outdated
| - changed the location of connect DEBUG calls so they'll still show in the | ||
| error case. |
There was a problem hiding this comment.
Fix Markdown lint errors: trailing spaces, capitalization, wrapping, and list spacing
Line 10 has a trailing space (MD009), the item should be capitalized to match other entries, and the text must wrap within 80 characters. Also, lists must be surrounded by blank lines (MD032)—add a blank line after the list before the next header. Apply this diff to lines 10–11:
@@ -10,2 +10,3 @@ ### Added
- - changed the location of connect DEBUG calls so they'll still show in the
- error case.
+ - Changed the location of connect DEBUG calls so they'll still show in the
+ error case.Then insert a blank line before the ## [1.5.2] - 2025-04-15 heading.
Committable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 GitHub Check: test
[failure] 10-10: Trailing spaces
packages/sdk/CHANGELOG.md:10:75 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1] https://github.com/DavidAnson/markdownlint/blob/v0.35.0/doc/md009.md
[failure] 11-11: Lists should be surrounded by blank lines
packages/sdk/CHANGELOG.md:11 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "error case."] https://github.com/DavidAnson/markdownlint/blob/v0.35.0/doc/md032.md
🪛 GitHub Actions: Lint SDK Markdown Files
[error] 10-10: markdownlint MD009/no-trailing-spaces: Trailing spaces detected (Expected: 0 or 2; Actual: 1). See https://github.com/DavidAnson/markdownlint/blob/v0.35.0/doc/md009.md
2 participants
WHY
Summary by CodeRabbit
Documentation
New Features
Style
Chores