Fix: support invoice creation without line items. Stripe. #16392

SokolovskyiK · 2025-04-22T16:15:06Z

Fixes #16354

What’s Fixed

This PR allows Stripe invoices to be created without line items, using:

collection_method: "send_invoice"
due_date or days_until_due

This works as expected in newer Stripe API versions, but fails in the old one (2020-03-02) with:

"Nothing to invoice for customer"

What Changed

Updated the apiVersion used inside this.stripe.sdk() from "2020-03-02" → "2022-11-15"

⚠️⚠️⚠️ WARNING – Potential Breaking Change ⚠️⚠️⚠️

This PR does not touch any other action logic, but upgrades the Stripe API version globally inside this.stripe.sdk().

That means:

Any other Stripe action relying on older behavior might break silently or throw unexpected errors.
Stripe's API is version-sensitive, and even minor field differences could trigger issues downstream.

Suggested Next Steps

Thoroughly test key actions (e.g. create-payment-intent, create-customer, etc.).
Consider making this version update opt-in (e.g. sdkNew()).
If merging globally, update changelog and notify integration users.

Why It Matters

This bug was open for 5+ days and is blocking users from creating draft invoices correctly — a required flow for many billing pipelines.

Let me know if you’d like help writing regression tests or scoping this into a safer "v2" variant!

Summary by CodeRabbit

Chores
- Updated Stripe integration to allow dynamic specification of API versions for enhanced flexibility.
- Incremented version numbers across multiple Stripe actions and source components for consistency and maintenance.

…e items

vercel · 2025-04-22T16:15:12Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
pipedream-docs-redirect-do-not-edit	⬜️ Ignored (Inspect)			Apr 24, 2025 3:54pm

vercel · 2025-04-22T16:15:13Z

@SokolovskyiK is attempting to deploy a commit to the Pipedreamers Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2025-04-22T16:15:15Z

"""

Walkthrough

The change modifies the sdk() method in the Stripe component to accept an optional apiVersion parameter with a default of "2020-03-02", allowing dynamic specification of the Stripe API version. The create-invoice action's Stripe SDK initialization was updated to explicitly use API version "2022-11-15". Additionally, version numbers for all Stripe actions and source components were incremented to reflect these updates. The package version was also increased from 0.6.2 to 0.6.3. No other changes to logic, error handling, or control flow were made.

Changes

File(s)	Change Summary
components/stripe/stripe.app.mjs	Modified `sdk()` method to accept optional `apiVersion` parameter with default `"2020-03-02"`
components/stripe/actions/create-invoice/create-invoice.mjs	Updated Stripe SDK client initialization to specify API version `"2022-11-15"`
components/stripe/actions/*/.mjs	Incremented version numbers from "0.1.0" to "0.1.1" or "0.0.1" to "0.0.2" in all action modules
components/stripe/sources/*/.mjs	Incremented version numbers from "0.1.1" to "0.1.2" or "0.1.2" to "0.1.3" in all source modules
components/stripe/package.json	Updated package version from "0.6.2" to "0.6.3"

Assessment against linked issues

Objective	Addressed	Explanation
Ensure Stripe SDK uses correct API version to support invoice creation as described (#16354)	✅

Suggested reviewers

GTFalcao

Poem

Stripe’s API gets a shiny new date,
Now invoices draft—no need to wait!
A hop and a skip, the version is set,
Bugs in the grass are no longer a threat.
With a twitch of my nose and a flick of my ear,
Stripe hops ahead—no more invoice fear!
🐇✨
"""

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

components/stripe/actions/create-invoice/create-invoice.mjs

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at packageResolve (node:internal/modules/esm/resolve:839:9)
at moduleResolve (node:internal/modules/esm/resolve:908:18)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

components/stripe/stripe.app.mjs

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at packageResolve (node:internal/modules/esm/resolve:839:9)
at moduleResolve (node:internal/modules/esm/resolve:908:18)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9932ba4 and 629d5bc.

📒 Files selected for processing (2)

components/stripe/actions/create-invoice/create-invoice.mjs (2 hunks)
components/stripe/stripe.app.mjs (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

components/stripe/actions/create-invoice/create-invoice.mjs
components/stripe/stripe.app.mjs

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: pnpm publish
GitHub Check: Verify TypeScript components
GitHub Check: Publish TypeScript components
GitHub Check: Lint Code Base

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

pipedream-component-development · 2025-04-22T16:15:25Z

Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified.

pipedream-component-development · 2025-04-22T16:15:26Z

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

components/stripe/stripe.app.mjs (1)
661-663: Beware of global Stripe API version upgrade
Upgrading apiVersion to "2022-11-15" unlocks draft‐invoices‐without‐items support but also shifts behavior across all Stripe resources (e.g., invoice, payment intents, customers). Please ensure you:

Add or update integration/regression tests for critical workflows (createPaymentIntent, createCustomer, createInvoice, etc.).

Update the project changelog and communicate this bump to users.

Consider making the API version configurable (via an environment variable) to allow opt‑in upgrades per integration.

Suggested diff to make version pluggable:
 sdk() {
   return stripe(this._apiKey(), {
-    apiVersion: "2022-11-15",
+    apiVersion: process.env.STRIPE_API_VERSION || "2022-11-15",
     maxNetworkRetries: 2,
   });
 }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 637b342 and 519bb2a.

📒 Files selected for processing (1)

components/stripe/stripe.app.mjs (1 hunks)

michelle0927

Thank you so much for your contribution! Approved and ready for QA!

SokolovskyiK · 2025-04-23T21:07:36Z

@michelle0927 Thank you =)

Update Stripe SDK API version to support invoice creation without lin…

519bb2a

…e items

adolfo-pd added the User submitted Submitted by a user label Apr 22, 2025

coderabbitai bot reviewed Apr 22, 2025

View reviewed changes

SokolovskyiK changed the title ~~Update Stripe SDK API version to support invoice creation without lin…~~ Fix: support invoice creation without line items. Stripe. Apr 22, 2025

pipedream-component-development requested a review from michelle0927 April 23, 2025 18:48

michelle0927 added 2 commits April 23, 2025 15:01

versions

f2a9ea1

pnpm-lock.yaml

9932ba4

michelle0927 previously approved these changes Apr 23, 2025

View reviewed changes

update apiVersion for create-invoice only

629d5bc

michelle0927 dismissed their stale review via 629d5bc April 24, 2025 15:54

michelle0927 approved these changes Apr 24, 2025

View reviewed changes

michelle0927 merged commit c4260a5 into PipedreamHQ:master Apr 25, 2025
10 of 11 checks passed

coderabbitai bot mentioned this pull request Apr 28, 2025

[FEATURE] Upgrade Pipedream Stripe App to Latest Stable API Version #16463

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix: support invoice creation without line items. Stripe. #16392

Fix: support invoice creation without line items. Stripe. #16392

Uh oh!

SokolovskyiK commented Apr 22, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Apr 22, 2025 •

edited

Loading

Uh oh!

vercel bot commented Apr 22, 2025

Uh oh!

coderabbitai bot commented Apr 22, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

pipedream-component-development commented Apr 22, 2025

Uh oh!

pipedream-component-development commented Apr 22, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

michelle0927 left a comment

Uh oh!

SokolovskyiK commented Apr 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Fix: support invoice creation without line items. Stripe. #16392

Fix: support invoice creation without line items. Stripe. #16392

Uh oh!

Conversation

SokolovskyiK commented Apr 22, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What’s Fixed

What Changed

⚠️⚠️⚠️ WARNING – Potential Breaking Change ⚠️⚠️⚠️

Suggested Next Steps

Why It Matters

Summary by CodeRabbit

Uh oh!

vercel bot commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Apr 22, 2025

Uh oh!

coderabbitai bot commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Assessment against linked issues

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

pipedream-component-development commented Apr 22, 2025

Uh oh!

pipedream-component-development commented Apr 22, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

michelle0927 left a comment

Choose a reason for hiding this comment

Uh oh!

SokolovskyiK commented Apr 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SokolovskyiK commented Apr 22, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Apr 22, 2025 •

edited

Loading

coderabbitai bot commented Apr 22, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)