Skip to content

servers: Don't use an auth token that expires within 1 second. #16459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 25, 2025
Merged

servers: Don't use an auth token that expires within 1 second. #16459

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7acb483
servers: Don't use an auth token that expires within 1 second.
Apr 25, 2025
6ab18b0
Update packages/sdk/CHANGELOG.md
danhsiung Apr 25, 2025
3a363b8
more lint fixes
Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/sdk/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,13 @@

# Changelog

## [1.5.4] - 2025-04-25

### Added

- Changed server-side authorized requests to refresh its auth token if it expires

Check failure on line 9 in packages/sdk/CHANGELOG.md

View workflow job for this annotation

GitHub Actions / test

Trailing spaces 

packages/sdk/CHANGELOG.md:9:82 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1] https://github.com/DavidAnson/markdownlint/blob/v0.35.0/doc/md009.md

Check failure on line 9 in packages/sdk/CHANGELOG.md

View workflow job for this annotation

GitHub Actions / test

Line length 

packages/sdk/CHANGELOG.md:9:81 MD013/line-length Line length [Expected: 80; Actual: 82] https://github.com/DavidAnson/markdownlint/blob/v0.35.0/doc/md013.md

Check failure on line 9 in packages/sdk/CHANGELOG.md

View workflow job for this annotation

GitHub Actions / test

Trailing spaces 

packages/sdk/CHANGELOG.md:9:82 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1] https://github.com/DavidAnson/markdownlint/blob/v0.35.0/doc/md009.md

Check failure on line 9 in packages/sdk/CHANGELOG.md

View workflow job for this annotation

GitHub Actions / test

Line length 

packages/sdk/CHANGELOG.md:9:81 MD013/line-length Line length [Expected: 80; Actual: 82] https://github.com/DavidAnson/markdownlint/blob/v0.35.0/doc/md013.md
within 1 second.

Check failure on line 10 in packages/sdk/CHANGELOG.md

View workflow job for this annotation

GitHub Actions / test

Lists should be surrounded by blank lines 

packages/sdk/CHANGELOG.md:10 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "within 1 second."] https://github.com/DavidAnson/markdownlint/blob/v0.35.0/doc/md032.md

Check failure on line 10 in packages/sdk/CHANGELOG.md

View workflow job for this annotation

GitHub Actions / test

Lists should be surrounded by blank lines 

packages/sdk/CHANGELOG.md:10 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "within 1 second."] https://github.com/DavidAnson/markdownlint/blob/v0.35.0/doc/md032.md
## [1.5.3] - 2025-04-18

Check failure on line 11 in packages/sdk/CHANGELOG.md

View workflow job for this annotation

GitHub Actions / test

Headings should be surrounded by blank lines 

packages/sdk/CHANGELOG.md:11 MD022/blanks-around-headings Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "## [1.5.3] - 2025-04-18"] https://github.com/DavidAnson/markdownlint/blob/v0.35.0/doc/md022.md

Check failure on line 11 in packages/sdk/CHANGELOG.md

View workflow job for this annotation

GitHub Actions / test

Headings should be surrounded by blank lines 

packages/sdk/CHANGELOG.md:11 MD022/blanks-around-headings Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "## [1.5.3] - 2025-04-18"] https://github.com/DavidAnson/markdownlint/blob/v0.35.0/doc/md022.md

### Added

Expand Down
2 changes: 1 addition & 1 deletion packages/sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@pipedream/sdk",
"type": "module",
"version": "1.5.3",
"version": "1.5.4",
"description": "Pipedream SDK",
"main": "./dist/server.js",
"module": "./dist/server.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/sdk/src/server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ export class BackendClient extends BaseClient {
let attempts = 0;
const maxAttempts = 2;

while (!this.oauthAccessToken || this.oauthAccessToken.expiresAt - Date.now() <= 0) {
while (!this.oauthAccessToken || this.oauthAccessToken.expiresAt - Date.now() < 1000) {
if (attempts > maxAttempts) {
throw new Error("ran out of attempts trying to retrieve oauth access token");
}
Expand Down
6 changes: 2 additions & 4 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading