-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Clarifying OAuth client usage for accounts API #16531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarifying OAuth client usage for accounts API #16531
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughThe documentation for the API connection process was revised to clarify the requirements for retrieving credentials of connected accounts for OAuth applications. The update removes references to environment-specific behavior and the use of Pipedream's OAuth clients, instead stating simply that credentials can be retrieved only if a custom OAuth client is used. This clarification was made in two locations within the documentation. Changes
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs-v2/pages/connect/api.mdx (2)
431-432: Remove environment context and clarify custom OAuth client requirement
The updated callout correctly removes the development/production distinction and focuses solely on the requirement that OAuth apps must use a custom OAuth client, aligning perfectly with the PR objectives.For consistency across the docs, consider unifying the link text:
- To retrieve credentials for a connected account for **OAuth** apps (Slack, Google Sheets, etc), the connected account must be using [your own OAuth client](/connect/managed-auth/oauth-clients/#using-a-custom-oauth-client). + To retrieve credentials for a connected account for **OAuth** apps (Slack, Google Sheets, etc), the connected account must use [a custom OAuth client](/connect/managed-auth/oauth-clients/#using-a-custom-oauth-client).
683-684: Consistent doc update for OAuth credential retrieval
This second callout mirrors the one above, removing environment-specific notes and reinforcing that only custom OAuth clients can retrieve credentials. Please ensure both instances remain in sync with identical wording and link targets.Align phrasing here as well, using the same “custom OAuth client” terminology for consistency.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
docs-v2/pages/connect/api.mdx(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Lint Code Base
- GitHub Check: pnpm publish
- GitHub Check: validate-links
WHY
Summary by CodeRabbit