-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Updating Google Ads proxy endpoint #16545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThe changes update both the documentation and internal configuration for the Google Ads component by replacing a specific proxy endpoint URL with a more generic one. The README documentation was also refined for JavaScript syntax consistency, including removal of unnecessary quotes, addition of trailing commas, and formatting improvements in code examples. Additionally, multiple action and source components had their version numbers incremented without any functional or logical changes. No changes were made to the logic, API usage, or the signatures of any exported entities. Changes
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/google_ads/actions/create-customer-list/create-customer-list.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/google_ads/actions/add-contact-to-list-by-email/add-contact-to-list-by-email.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/google_ads/sources/new-campaign-created/new-campaign-created.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (7)
✅ Files skipped from review due to trivial changes (7)
⏰ Context from checks skipped due to timeout of 90000ms (3)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
components/google_ads/README.md(2 hunks)components/google_ads/google_ads.app.mjs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Verify TypeScript components
- GitHub Check: pnpm publish
- GitHub Check: Lint Code Base
- GitHub Check: Publish TypeScript components
🔇 Additional comments (4)
components/google_ads/google_ads.app.mjs (1)
97-97:✅ Verification successful
Verify removal of legacy proxy endpoint
The
_baseUrl()now points to the generic proxy (https://googleads.m.pipedream.net). Please ensure there are no remaining references to the old random subdomain in the codebase by running:
🏁 Script executed:
#!/bin/bash rg -n "eolid4dq1k0t9hi"Length of output: 23
No legacy proxy references found
The
rg -n "eolid4dq1k0t9hi"search returned no matches, confirming that the old random subdomain has been fully removed.components/google_ads/README.md (3)
33-36: Good: Consistent JavaScript object formattingThe example now uses unquoted keys where appropriate, includes trailing commas, and terminates with semicolons, which enhances readability and aligns with modern JavaScript style.
53-58: Approve: Second example updated for syntax consistencyThe second code snippet follows the same formatting improvements—clean header key, trailing commas, and semicolon at the end—making both examples uniform.
61-61: Confirm updated proxy endpoint in docsThe README now correctly references the new proxy URL (
https://googleads.m.pipedream.net), matching the_baseUrl()implementation.
WHY
Summary by CodeRabbit
Documentation
Refactor
Chores