Skip to content

Conversation

@jsendo
Copy link
Contributor

@jsendo jsendo commented May 20, 2025

WHY

Summary by CodeRabbit

  • New Features

    • Added a new method to retrieve the raw access token directly from the BackendClient.
  • Documentation

    • Updated the changelog to reflect the new version and feature addition.
  • Chores

    • Bumped the SDK package version to 1.6.3.

@vercel
Copy link

vercel bot commented May 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Ignored (Inspect) Visit Preview May 20, 2025 9:16pm
pipedream-docs ⬜️ Ignored (Inspect) May 20, 2025 9:16pm
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) May 20, 2025 9:16pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 20, 2025

Caution

Review failed

The pull request is closed.

"""

Walkthrough

A new public getter, rawAccessToken, was added to the BackendClient class in the SDK. The changelog and package version were updated to reflect this addition, with the version incremented to 1.6.3. No other logic or existing functionality was modified.

Changes

File(s) Change Summary
packages/sdk/CHANGELOG.md Added changelog entry for version 1.6.3, documenting the new rawAccessToken getter.
packages/sdk/package.json Updated package version from 1.6.2 to 1.6.3.
packages/sdk/src/server/index.ts Added rawAccessToken() public method to BackendClient for retrieving the raw access token.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant BackendClient

    Client->>BackendClient: Call rawAccessToken()
    alt Static token exists
        BackendClient-->>Client: Return static access token
    else No static token
        BackendClient->>BackendClient: ensureValidOauthAccessToken()
        BackendClient-->>Client: Return OAuth access token
    end
Loading

Poem

A hop and a skip, a new token to show,
BackendClient now lets the raw access flow.
The changelog is fresh, the version’s anew,
1.6.3 brings something for you!
With tokens in paw, I leap through the code—
🐇 Onward and upward, down the release road!
"""

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/sdk/src/server/index.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at Object.getPackageJSONURL (node:internal/modules/package_json_reader:255:9)
at packageResolve (node:internal/modules/esm/resolve:767:81)
at moduleResolve (node:internal/modules/esm/resolve:853:18)
at defaultResolve (node:internal/modules/esm/resolve:983:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:799:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:723:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:706:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:307:38)
at #link (node:internal/modules/esm/module_job:163:49)

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 8026f74 and b8d2b0c.

📒 Files selected for processing (1)
  • packages/sdk/src/server/index.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@linear
Copy link

linear bot commented May 20, 2025

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
packages/sdk/CHANGELOG.md (1)

5-10: Consider using consistent terminology between implementation and documentation

The changelog refers to rawAccessToken as a "getter", but it's implemented as a method, not a getter property. This could lead to confusion for API consumers.

Either modify the changelog to refer to it as a method:

- Added `rawAccessToken` getter to `BackendClient`
+ Added `rawAccessToken()` method to `BackendClient`

Or consider implementing it as an actual getter:

/**
 * Gets the raw access token without Authorization header formatting.
 */
public get rawAccessToken(): string | Promise<string> {
  if (this.staticAccessToken) {
    return this.staticAccessToken;
  }
  return this.ensureValidOauthAccessToken();
}

Note that in version 1.6.1, you added a similar feature called rawToken to BrowserClient, so maintaining consistency is important.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 0e9798c and 8026f74.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • packages/sdk/CHANGELOG.md (1 hunks)
  • packages/sdk/package.json (1 hunks)
  • packages/sdk/src/server/index.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: pnpm publish
  • GitHub Check: test
  • GitHub Check: Lint Code Base
🔇 Additional comments (1)
packages/sdk/package.json (1)

4-4: Looks good: Version increment is appropriate

The version bump from 1.6.2 to 1.6.3 correctly follows semantic versioning for adding a new feature without breaking changes.

@jsendo jsendo merged commit 610e27c into master May 20, 2025
9 of 10 checks passed
@jsendo jsendo deleted the je/dj-3290-add-raw-access-token-getter-to-backend-client branch May 20, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant