- 
                Notifications
    You must be signed in to change notification settings 
- Fork 5.5k
feat: add zoom admin actions #16879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add zoom admin actions #16879
Conversation
| The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
 | 
| Someone is attempting to deploy a commit to the Pipedreamers Team on Vercel. A member of the Team first needs to authorize it. | 
| """ WalkthroughTwo new Zoom Admin actions are introduced: one to fetch all recordings for a specific meeting, and another to list all participants of a past meeting. Supporting these, the Zoom Admin app module now provides methods for listing meeting recordings and past meeting participants via the Zoom API, both supporting pagination. The package version was updated accordingly. Changes
 Sequence Diagram(s)sequenceDiagram
    participant User
    participant GetMeetingRecordingsAction
    participant ZoomAdminApp
    participant ZoomAPI
    User->>GetMeetingRecordingsAction: Trigger action with meeting ID
    GetMeetingRecordingsAction->>ZoomAdminApp: Call listMeetingRecordings(meetingId, params)
    ZoomAdminApp->>ZoomAPI: GET /meetings/{meetingId}/recordings (with pagination)
    ZoomAPI-->>ZoomAdminApp: Return recordings data
    ZoomAdminApp-->>GetMeetingRecordingsAction: Return recordings
    GetMeetingRecordingsAction-->>User: Return recordings list (optionally with access token)
sequenceDiagram
    participant User
    participant ListPastMeetingParticipantsAction
    participant ZoomAdminApp
    participant ZoomAPI
    User->>ListPastMeetingParticipantsAction: Trigger action with meeting ID
    ListPastMeetingParticipantsAction->>ZoomAdminApp: Call listPastMeetingParticipants(meetingId)
    ZoomAdminApp->>ZoomAPI: GET /past_meetings/{meetingId}/participants (with pagination)
    ZoomAPI-->>ZoomAdminApp: Return participants data
    ZoomAdminApp-->>ListPastMeetingParticipantsAction: Return participants
    ListPastMeetingParticipantsAction-->>User: Return participants list
Poem
 Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
 components/zoom_admin/actions/list-past-meeting-participants/list-past-meeting-participants.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/zoom_admin/zoom_admin.app.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/zoom_admin/actions/get-meeting-recordings/get-meeting-recordings.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
 ✅ Files skipped from review due to trivial changes (1)
 🚧 Files skipped from review as they are similar to previous changes (3)
 ⏰ Context from checks skipped due to timeout of 90000ms (3)
 ✨ Finishing Touches
 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit: 
 SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
 Other keywords and placeholders
 CodeRabbit Configuration File ( | 
| Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified. | 
| Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist: 
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
- components/zoom_admin/actions/get-meeting-recordings/get-meeting-recordings.mjs(1 hunks)
- components/zoom_admin/actions/list-past-meeting-participants/list-past-meeting-participants.mjs(1 hunks)
- components/zoom_admin/zoom_admin.app.mjs(1 hunks)
🔇 Additional comments (4)
components/zoom_admin/zoom_admin.app.mjs (2)
395-404: Method implementation looks good.The
listPastMeetingParticipantsmethod correctly follows the established patterns in the codebase, uses the appropriate API endpoint, and handles pagination consistently with other methods.
405-415: Method implementation looks good.The
listMeetingRecordingsmethod correctly follows the established patterns, uses the appropriate API endpoint, and properly spreads additional parameters while maintaining pagination support.components/zoom_admin/actions/list-past-meeting-participants/list-past-meeting-participants.mjs (1)
1-33: Well-structured action implementation.The action follows all established patterns:
- Proper imports and metadata
- Correct prop definitions using the app's meeting propDefinition
- Appropriate use of the paginate utility with the correct data key ("participants")
- Consistent error message formatting and export pattern
components/zoom_admin/actions/get-meeting-recordings/get-meeting-recordings.mjs (1)
1-42: Well-implemented action with proper parameter handling.The action implementation is excellent:
- Follows established patterns and structure
- Properly handles the optional
downloadAccessTokenparameter by passing it in the params object- Uses correct data key ("recordings") for pagination
- Maintains consistency with the meeting prop definition and export patterns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jocarino lgtm! However you also need to increment the minor version in package.json in the meantime I'm going to move it to Ready for QA! Thanks for this contribution!
| Hi everyone, all test cases are passed! Ready for release! Test report | 
| hi @jcortes lmk if you need anything else from me (Obrigado!) | 
| Closed this PR in favor of #16895 | 
WHY
Adding missing actions for zoom admin
Listing past meeting participants
Get meeting recordings
Summary by CodeRabbit