-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Danny/docs/mcp tool mode #16890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Danny/docs/mcp tool mode #16890
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Warning Rate limit exceeded@dannyroosevelt has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 10 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe documentation for Pipedream's MCP server was updated to clarify built-in user authentication, describe two tool interaction modes (sub-agent and tools-only), and provide example schemas for each. The request parameter section was revised to specify required headers or query parameters, and example code was updated to reflect these changes. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (4)
docs-v2/pages/connect/mcp/developers.mdx (4)
152-159: Refine wording for clarity
Consider tightening the sentence at line 153 by removing “of” and rephrasing for conciseness. For example:-When using Pipedream MCP with sub-agent mode enabled, all of the tools that you expose to your LLM take only a single input: **`instruction`**. +When using Pipedream MCP in sub-agent mode, all tools you expose to your LLM take a single input: **`instruction`**.🧰 Tools
🪛 LanguageTool
[style] ~153-~153: Consider removing “of” to be more concise
Context: ...edream MCP with sub-agent mode enabled, all of the tools that you expose to your LLM take ...(ALL_OF_THE)
193-198: Improve voice and punctuation in dynamic props bullets
The passive construction and missing comma at line 195 can be refined. For example:-- Tools that use dynamic props aren't able to be configured in one-shot since the full prop definition isn't known until certain inputs are defined. +- Tools that use dynamic props cannot be configured in one shot, as the full prop definition isn’t known until certain inputs are defined.This makes the guidance clearer and removes the passive voice.
🧰 Tools
🪛 LanguageTool
[style] ~195-~195: Avoid the passive voice after ‘to be able to’.
Context: ...#reload-component-props) aren't able to be configured in one-shot since the full prop definit...(ABLE_TO_PASSIVE)
[uncategorized] ~195-~195: Possible missing comma found.
Context: ...ps) aren't able to be configured in one-shot since the full prop definition isn't kn...(AI_HYDRA_LEO_MISSING_COMMA)
199-200: Remove placeholder TODO comments
These JSX comments are placeholders and should be replaced with real content or removed before publishing. Do you want assistance drafting the missing guidance for async options and dynamic props?
303-317: Fix typo and ensure consistency in “Params” section
At line 304, “Pipedram’s” should be “Pipedream’s.” Also double-check each header/query-param name for consistency with the SDK.-- Below are params that you should send with every HTTP request to Pipedram's MCP server. +- Below are params that you should send with every HTTP request to Pipedream’s MCP server.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
docs-v2/pages/connect/mcp/developers.mdx(5 hunks)
🧰 Additional context used
🪛 LanguageTool
docs-v2/pages/connect/mcp/developers.mdx
[style] ~153-~153: Consider removing “of” to be more concise
Context: ...edream MCP with sub-agent mode enabled, all of the tools that you expose to your LLM take ...
(ALL_OF_THE)
[style] ~195-~195: Avoid the passive voice after ‘to be able to’.
Context: ...#reload-component-props) aren't able to be configured in one-shot since the full prop definit...
(ABLE_TO_PASSIVE)
[uncategorized] ~195-~195: Possible missing comma found.
Context: ...ps) aren't able to be configured in one-shot since the full prop definition isn't kn...
(AI_HYDRA_LEO_MISSING_COMMA)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: validate-links
- GitHub Check: Lint Code Base
🔇 Additional comments (3)
docs-v2/pages/connect/mcp/developers.mdx (3)
7-9: Introduce callout for built-in user authentication
Great addition—this highlights that Pipedream handles user auth out of the box, reducing integration overhead. The anchor link to#user-account-connectionsappears correct.
144-150: Add “Tool modes” overview section
This new section clearly presents the two interaction modes (sub-agent vs. tools-only) and aligns with the PR’s goal of clarifying tool invocation.
160-162: Warn about future LLM usage costs in Beta
This warning is important to set expectations about token costs once the Beta period ends. Nice UX callout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (1)
docs-v2/pages/connect/mcp/developers.mdx (1)
337-337: Useprocess.env.MCP_SERVER_URLinstead of undefinedMCP_SERVER_URL
MCP_SERVER_URLis not declared. Reference it viaprocess.env.MCP_SERVER_URLor define it above to avoid runtime errors.
🧹 Nitpick comments (2)
docs-v2/pages/connect/mcp/developers.mdx (2)
144-150: Consistent wording for tool modes section
The heading uses "Tool modes" but the description refers to "methods". Consider standardizing the term—e.g., "Pipedream MCP supports two modes for interacting with tools:"—for clarity and consistency.
302-309: Typo: "Pipedram's" → "Pipedream's"
There's a misspelling in the first bullet:
"Pipedram's MCP server"should be "Pipedream's MCP server".
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
docs-v2/pages/connect/mcp/developers.mdx(5 hunks)
🧰 Additional context used
🪛 LanguageTool
docs-v2/pages/connect/mcp/developers.mdx
[style] ~153-~153: Consider removing “of” to be more concise
Context: ...edream MCP with sub-agent mode enabled, all of the tools that you expose to your LLM take ...
(ALL_OF_THE)
[style] ~195-~195: Avoid the passive voice after ‘to be able to’.
Context: ...#reload-component-props) aren't able to be configured in one-shot since the full prop definit...
(ABLE_TO_PASSIVE)
[uncategorized] ~195-~195: Possible missing comma found.
Context: ...ps) aren't able to be configured in one-shot since the full prop definition isn't kn...
(AI_HYDRA_LEO_MISSING_COMMA)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Lint Code Base
- GitHub Check: validate-links
🔇 Additional comments (2)
docs-v2/pages/connect/mcp/developers.mdx (2)
7-9: Approve: Clear built-in authentication callout
This newCallouteffectively informs developers about Pipedream Connect's built-in user authentication and links to the relevant section.
133-133: No actionable content on this blank line.
WHY
Summary by CodeRabbit