Hubspot update search-crm #16896
Hubspot update search-crm #16896
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
WalkthroughThe changes add support for both exact and partial match searching in the HubSpot CRM search action by introducing an Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant SearchCRMAction
participant HubSpotAPI
User->>SearchCRMAction: Invoke run({searchValue, exactMatch, ...})
alt exactMatch == true
SearchCRMAction->>HubSpotAPI: Search with EQ filter
HubSpotAPI-->>SearchCRMAction: Return results
SearchCRMAction-->>User: Return exact matches
else exactMatch == false
loop Paginate results
SearchCRMAction->>HubSpotAPI: Search with limit, no filter
HubSpotAPI-->>SearchCRMAction: Return page of results
end
SearchCRMAction->>SearchCRMAction: Filter results client-side (partial match)
SearchCRMAction-->>User: Return partial matches
end
Assessment against linked issues
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/hubspot/actions/search-crm/search-crm.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
components/hubspot/actions/search-crm/search-crm.mjs(7 hunks)components/hubspot/package.json(1 hunks)
🧰 Additional context used
🪛 Biome (1.9.4)
components/hubspot/actions/search-crm/search-crm.mjs
[error] 220-220: Avoid the delete operator which can impact performance.
Unsafe fix: Use an undefined assignment instead.
(lint/performance/noDelete)
[error] 291-292: Change to an optional chain.
Unsafe fix: Change to an optional chain.
(lint/complexity/useOptionalChain)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Verify TypeScript components
- GitHub Check: pnpm publish
- GitHub Check: Lint Code Base
- GitHub Check: Publish TypeScript components
🔇 Additional comments (6)
components/hubspot/package.json (1)
3-3: LGTM - Appropriate version bump.The version increment from
1.2.2to1.2.3correctly reflects the functional enhancements made to the search-crm action.components/hubspot/actions/search-crm/search-crm.mjs (5)
11-11: LGTM - Import needed for pagination.The
DEFAULT_LIMITimport is correctly added to support the new pagination functionality for partial matches.
20-20: LGTM - Component version increment.The version bump appropriately reflects the new exactMatch functionality and pagination support.
37-43: LGTM - Well-defined property with good defaults.The
exactMatchproperty is properly configured with:
- Clear description explaining the behavior
- Sensible default of
truefor backward compatibility- Appropriate boolean type
108-108: LGTM - Updated description reflects new functionality.The description correctly explains that the search behavior depends on the exactMatch setting.
271-282: LGTM - Clear separation of exact vs partial match logic.The conditional logic properly handles the two search modes:
- Exact matches use server-side filtering with EQ operator
- Partial matches use pagination with client-side filtering
This approach makes sense given HubSpot API limitations for partial matching.
jcortes
left a comment
jcortes
left a comment
There was a problem hiding this comment.
@michelle0927 lgtm! Ready for QA!
Resolves #16888
Summary by CodeRabbit
New Features
Chores