Fix SDK bug in the deployTrigger method
#16934
Conversation
The `deployTrigger` method was ignoring the `workflowId` argument when calling the API, which prevented the new trigger from emitting events to the target workflow.
jverce
added
bug
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
@jverce is attempting to deploy a commit to the Pipedreamers Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThis update increments the SDK version to 1.6.5, documents the release in the changelog, and modifies the Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant BaseClient
participant API
Caller->>BaseClient: deployTrigger({ workflowId })
BaseClient->>API: POST /deploy-trigger { workflow_id: workflowId }
API-->>BaseClient: Response
BaseClient-->>Caller: Result
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/sdk/src/shared/index.tsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🔇 Additional comments (3)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a bug in the deployTrigger method by ensuring that the workflowId is correctly passed to the API.
- Added workflow_id to the payload in deployTrigger
- Version bump and changelog update for the SDK
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/sdk/src/shared/index.ts | Adds the workflow_id field to the API payload |
| packages/sdk/package.json | Updates the package version to 1.6.5 |
| packages/sdk/CHANGELOG.md | Documents the fix for deployTrigger |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
2 participants
WHY
The
deployTriggermethod was ignoring theworkflowIdargument when calling the API, which prevented the new trigger from emitting events to the target workflow.Summary by CodeRabbit
Bug Fixes
Chores