Skip to content

Firebase - get token #17027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+18 −1
Open

Firebase - get token #17027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
baf84e1
add firebase get token action
andrewjschuang Jun 6, 2025
dbc15ae
bump version
andrewjschuang Jun 6, 2025
50aef1a
Merge branch 'master' into firebase-get-token
andrewjschuang Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions components/firebase_admin_sdk/actions/get-token/get-token.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import firebase from "../../firebase_admin_sdk.app.mjs";

export default {
key: "firebase_admin_sdk-get-token",
name: "Get Token",
description: "Retrieves the OAuth token from a Firestore admin account for API requests. [See the documentation](https://firebase.google.com/docs/admin/setup/#initialize_the_sdk_in_non-google_environments)",
version: "0.0.1",
type: "action",
props: {
firebase,
},
async run({ $ }) {
const token = await this.firebase._getToken();
$.export("$summary", "Succesfully retrieved OAuth token");
return token;
},
Comment on lines +12 to +16
Copy link
Contributor

@coderabbitai coderabbitai bot Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Add error handling and consider security implications.

The current implementation has several concerns:

  1. Missing error handling: The _getToken() call should be wrapped in try-catch
  2. Security consideration: Returning the raw OAuth token may expose sensitive credentials in logs or responses
  async run({ $ }) {
-    const token = await this.firebase._getToken();
-    $.export("$summary", "Succesfully retrieved OAuth token");
-    return token;
+    try {
+      const token = await this.firebase._getToken();
+      $.export("$summary", "Successfully retrieved OAuth token");
+      // Consider if returning the full token is necessary for security
+      return {
+        token,
+        // Or return limited info: tokenType: typeof token, length: token?.length
+      };
+    } catch (error) {
+      throw new Error(`Failed to retrieve OAuth token: ${error.message}`);
+    }
  },
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
async run({ $ }) {
const token = await this.firebase._getToken();
$.export("$summary", "Succesfully retrieved OAuth token");
return token;
},
async run({ $ }) {
try {
const token = await this.firebase._getToken();
$.export("$summary", "Successfully retrieved OAuth token");
// Consider if returning the full token is necessary for security
return {
token,
// Or return limited info: tokenType: typeof token, length: token?.length
};
} catch (error) {
throw new Error(`Failed to retrieve OAuth token: ${error.message}`);
}
},
🤖 Prompt for AI Agents 
In components/firebase_admin_sdk/actions/get-token/get-token.mjs around lines 12
to 16, the code lacks error handling for the asynchronous _getToken() call and
directly returns the raw OAuth token, which can expose sensitive information.
Wrap the _getToken() call in a try-catch block to handle potential errors
gracefully, and avoid returning the raw token directly; instead, consider
returning a masked version or a success indicator without exposing the token in
logs or responses.

};
2 changes: 1 addition & 1 deletion components/firebase_admin_sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@pipedream/firebase_admin_sdk",
"version": "0.1.0",
"version": "0.1.1",
"description": "Pipedream Firebase Admin SDK Components",
"main": "firebase_admin_sdk.app.mjs",
"keywords": [
Expand Down
Loading