-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Hubspot - New or Updated Contact Source updates #17143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThis update modifies the Hubspot "New or Updated Contact" source to conditionally sort by creation date when the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant SourceComponent
participant HubspotAPI
loop For each page
SourceComponent->>HubspotAPI: Fetch results with params (sort by createdate if newOnly)
HubspotAPI-->>SourceComponent: Return results
loop For each result
SourceComponent->>SourceComponent: Extract timestamp (ts)
alt ts > after (or after not set)
SourceComponent->>SourceComponent: isRelevant(result, ts)
alt isRelevant is true
SourceComponent->>User: Emit event
SourceComponent->>SourceComponent: Update maxTs and after
end
end
end
end
Assessment against linked issues
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/hubspot/sources/new-contact-property-change/new-contact-property-change.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/hubspot/sources/new-deal-property-change/new-deal-property-change.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/hubspot/sources/new-company-property-change/new-company-property-change.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (26)
⏰ Context from checks skipped due to timeout of 90000ms (4)
🔇 Additional comments (28)
|
GTFalcao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* update to new-or-updated-contact * pnpm-lock.yaml * versions
Resolves #17137
Summary by CodeRabbit
Bug Fixes
Chores