-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Bug Fix - OpenRouter MCP Server Schema Validation Erro #17203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
WalkthroughThe version numbers for two OpenRouter action modules and the package were incremented. The Changes
Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/openrouter/actions/send-chat-completion-request/send-chat-completion-request.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/openrouter/actions/send-completion-request/send-completion-request.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
components/openrouter/actions/send-chat-completion-request/send-chat-completion-request.mjs (1)
158-158: Consider handling undefined models value.Since
modelsis now optional,this.modelscould be undefined. While this may work fine if the OpenRouter API handles undefined values gracefully, consider conditionally including the property to avoid sending undefined values:- models: this.models, + ...(this.models && { models: this.models }),components/openrouter/actions/send-completion-request/send-completion-request.mjs (1)
157-157: Consider handling undefined models value.Since
modelsis now optional,this.modelscould be undefined. While this may work fine if the OpenRouter API handles undefined values gracefully, consider conditionally including the property to avoid sending undefined values:- models: this.models, + ...(this.models && { models: this.models }),
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (3)
components/openrouter/actions/send-chat-completion-request/send-chat-completion-request.mjs(2 hunks)components/openrouter/actions/send-completion-request/send-completion-request.mjs(2 hunks)components/openrouter/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: pnpm publish
- GitHub Check: Lint Code Base
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
🔇 Additional comments (5)
components/openrouter/package.json (1)
3-3: LGTM! Appropriate version increment for bug fix.The patch version increment from 0.1.0 to 0.1.1 correctly follows semantic versioning for this bug fix addressing schema validation errors.
components/openrouter/actions/send-chat-completion-request/send-chat-completion-request.mjs (2)
8-8: LGTM! Appropriate version increment.The patch version increment correctly reflects the bug fix changes made to the schema validation.
109-110: LGTM! Correctly addresses the schema validation issue.Making the
modelsproperty optional resolves the reported issue where bothmodelandmodelswere incorrectly required. This change aligns the implementation with the documented behavior where onlymodelis required.components/openrouter/actions/send-completion-request/send-completion-request.mjs (2)
7-7: LGTM! Appropriate version increment.The patch version increment correctly reflects the bug fix changes made to the schema validation.
108-109: LGTM! Correctly addresses the schema validation issue.Making the
modelsproperty optional resolves the reported issue where bothmodelandmodelswere incorrectly required. This change aligns the implementation with the documented behavior where onlymodelis required.
luancazarine
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @michelle0927, LGTM! Ready for QA!
Resolves #17097
The documentation shows that
modelis required, andmodelsis optional. I think the problem was that we had bothmodelandmodelsprops required.Summary by CodeRabbit