-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Connect token opts and oauth_app_id #17249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe documentation for MCP server integration was updated to clarify which parameters can be passed via headers or query parameters. Four new optional HTTP headers were added, each described and referenced with additional documentation. The example JavaScript code was also revised to demonstrate usage of one of the new headers. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs-v2/pages/connect/mcp/developers.mdx (2)
317-321: Table formatting inconsistencyIn the “Query Param” column you’ve inserted the literal text “Must be passed as header”.
That breaks the semantic intent of the column (which expects the actual query-param key).
Consider replacing with something neutral like—/N/A, or add a dedicated “Header-only?” column.-| `x-pd-oauth-app-id` | Must be passed as header | `oa_xxxxxxx` ... +| `x-pd-oauth-app-id` | — | `oa_xxxxxxx` ...Same for the other three new rows.
351-352: Minor example driftOnly
x-pd-oauth-app-idis demonstrated in the sample request.
Since the preceding table introduces three additional header-only parameters (x-pd-webhook-uri,x-pd-error-redirect-uri,x-pd-success-redirect-uri), it may help readers if the snippet shows at least one of those as well, or adds a comment pointing to the table for the full list.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
docs-v2/pages/connect/mcp/developers.mdx(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: pnpm publish
- GitHub Check: validate-links
- GitHub Check: Lint Code Base
🔇 Additional comments (1)
docs-v2/pages/connect/mcp/developers.mdx (1)
305-306: Clarity improved – good call-outExplicitly noting that “most” parameters work in both headers and query-strings removes a common source of confusion.
WHY
Summary by CodeRabbit