-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Updating sftp_password_based_auth #17278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
WalkthroughThe changes update the version numbers in both the Changes
Assessment against linked issues
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/sftp_password_based_auth/actions/upload-file/upload-file.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/sftp_password_based_auth/package.json (1)
3-3: Remember to update CHANGELOG / release notes alongside the package version bump
Incrementing the package to0.5.0is a breaking-change signal for consumers. Make sure a corresponding CHANGELOG entry exists so downstream users understand what changed.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
components/sftp_password_based_auth/actions/upload-file/upload-file.mjs(1 hunks)components/sftp_password_based_auth/package.json(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: pnpm publish
- GitHub Check: Lint Code Base
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
🔇 Additional comments (2)
components/sftp_password_based_auth/package.json (1)
17-17: Double-check compatibility of@pipedream/sftp@^0.5.0before publishing
The dependency also jumps a major minor version. Please verify its release notes and run the component’s tests / integration suite to confirm no API breakages surfaced. If everything passes, you’re good.components/sftp_password_based_auth/actions/upload-file/upload-file.mjs (1)
12-12: Version string correctly aligned with package bump – LGTM
The action’sversionfield now matches the overall component update. No other functional changes observed.
luancazarine
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @GTFalcao, LGTM! Ready for QA!
Closes #17252
Summary by CodeRabbit